Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nullable fields #15

Closed
wants to merge 1 commit into from
Closed

Enable nullable fields #15

wants to merge 1 commit into from

Conversation

sjones6
Copy link

@sjones6 sjones6 commented Apr 3, 2019

When default: null, mongoose allows fields to be nullable. However, the JSON schema created still expects the field to be a string—which causes any null values to fail validation. This accounts for that scenario.

Happy to discuss more or shift approach.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 98.142% when pulling ba6ba5e on WireWheel:master into b1a8446 on DScheglov:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 98.142% when pulling ba6ba5e on WireWheel:master into b1a8446 on DScheglov:master.

@DScheglov
Copy link
Owner

DScheglov commented Apr 16, 2020

Implemented in v1.3.0

@DScheglov DScheglov closed this Apr 16, 2020
@sjones6
Copy link
Author

sjones6 commented Apr 16, 2020

Thanks @DScheglov !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants