Auditlog cleanup and update

[Plerx2493]

Summary

I started to cleanup the GetAuditLogs method on DiscordGuild and updated the AuditLogActionType Enum

Notes

Feel free to give me feedback and point out additional methods i can cleanup in this scope. I thought about rewriting other auditlog related sections but i dont know entirely how it works

Tasks

• Implement missing entry types
• Implement parsing of missing types
• Implement missing AuditLog event

[Plerx2493]

i have not implemented a new type for the new actionTypes because i didnt know if we want to continue with this monster method

[Plerx2493]

The editorconfig is against using var. Should i replace it in all methods i clean up? its used everywhere

[akiraveliara]

please do, and if you can, also run other format rules like file-scoped namespaces

[Plerx2493]

@akiraveliara should i enforce all editorconfig warnings or only those which only affects files i already have changes in?

[Plerx2493]

There are several naming rules broken but they also make changes in DiscordClient.cs

[akiraveliara]

only in files you touch for now, so as to avoid huge merge conflicts

[Plerx2493]

ok i got it

[Plerx2493]

145...

[Plerx2493]

Now its a huge PR for a minor change ^^

[akiraveliara]

you can always make the PR extend to more audit log functionality if you want (:

[akiraveliara]

but seriously, that's fine. it'll be a little annoying when it comes to reverting commits, but eh

[Plerx2493]

My plan is to implement the missing auditlogtypes. I will see what I can do after that

[akiraveliara]

may close #1569

[InFTord]

more documentation required, but other than that LGTM

[Plerx2493]

may close #1569

I haven't had a chance to check it yet, but I can look at it later.

[Plerx2493]

more documentation required, but other than that LGTM

xml docs on the new methods or anything else? I have those in mind

[InFTord]

yes, xmldocs

[akiraveliara]

lgtm, will wait for preliminary test results before merging - if you want to split the types off into their own files, feel free

[Plerx2493]

lgtm, will wait for preliminary test results before merging - if you want to split the types off into their own files, feel free

currently working on it

[Plerx2493]

Should be ready now

[InFTord]

LGTM

[Plerx2493]

Missing change keys:

DiscordAuditLogAutoModerationRuleEntry:

• $add_keyword_filter
• $remove_keyword_filter

DiscordAuditLogIntegrationEntry:

• type
• name

DiscordAuditLogThreadEventEntry:

• flags

[akiraveliara]

once the change keys are added we can merge this as far as i'm concerned

[Plerx2493]

should be ready to merge