consolidate and improve internal rest infrastructure #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and use pre-computed count properties instead of Enumerable.Count()
…/consolidate-rest
akiraveliara
changed the title
Naamloos
approved these changes
Sep 20, 2023
InFTord
reviewed
Sep 25, 2023
Directory.Packages.props
Outdated
| <PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="7.0.0"/> | ||
| <PackageVersion Include="Microsoft.Extensions.DependencyModel" Version="7.0.0"/> | ||
| <PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="7.0.1"/> | ||
| <PackageVersion Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="all"/> |
There was a problem hiding this comment.
re-add SourceLink, required for our docs bot to function iirc
InFTord
approved these changes
Sep 25, 2023
…dsharpplus into fix/consolidate-rest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rewoks the whole rest client to be faster and slightly more accurate
Details
Future Notes
this PR does NOT update the rest client to match the current API specification yet, that work will have to be done in a later PR