Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add polls support #1813

Merged
merged 8 commits into from Apr 20, 2024
Merged

feat: Add polls support #1813

merged 8 commits into from Apr 20, 2024

Conversation

VelvetToroyashi
Copy link
Member

Summary

Adds support for polls

Notes

Resolves #1812

@VelvetToroyashi VelvetToroyashi self-assigned this Mar 23, 2024
@VelvetToroyashi VelvetToroyashi linked an issue Mar 23, 2024 that may be closed by this pull request
@akiraveliara akiraveliara added this to the v5.0 milestone Mar 23, 2024
@VelvetToroyashi VelvetToroyashi marked this pull request as ready for review March 25, 2024 07:16
Copy link
Contributor

@akiraveliara akiraveliara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall good, some formatting grievances (using order, for example) and of course namespaces should be below usings.

Comment on lines 1 to 2
<wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">
<s:Boolean x:Key="/Default/CodeInspection/NamespaceProvider/NamespaceFoldersToSkip/=entities_005Cchannel_005Cmessage_005Cpoll/@EntryIndexedValue">True</s:Boolean></wpf:ResourceDictionary>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider gitignoring this

@DubyaDude DubyaDude mentioned this pull request Apr 10, 2024
@Plerx2493
Copy link
Member

Just as a note, the pr in discord/discord-api-docs was merged in to main. This pr is ready to merge when #1835 is merged

* Remove DotSettings file

* Added DotSettings to gitignore

* Fix namespace/usings ordering

* Missed a namespace/using order

* Added poll to discord message

* Fix message builder check

* Fix DiscordPoll Builder

* Update other messages

* Make DiscordPollLayoutType nullable for create payload

* Add new poll intents

* split add and remove in dispatch

* Fix documentation

* tag out intents causing error

* Add json property to DiscordPollMedia Emoji

* Move PollCreatePayload to DSharpPlus.Net.Abstractions

* Fix build error

* Use using for PollCreatePayload in DiscordMessageBuilder

* Fix using order

* Add Ending Poll and Get All Poll Answer Voters

* Remove commented out intents (they are live)

* Wow, poll permission!

* Move expire to endpoints

* Updated FULL_PERMS

* Make expiry nullable. 'is marked as nullable to support non-expiring polls in the future'

* fix build error

* Pass DiscordPollBuilder along publicly
@akiraveliara akiraveliara merged commit a90b8e4 into master Apr 20, 2024
1 check passed
@akiraveliara akiraveliara deleted the velvet/feat/polls branch April 20, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polls support
4 participants