New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add polls support #1813
feat: Add polls support #1813
Conversation
c222db0
to
68df429
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall good, some formatting grievances (using order, for example) and of course namespaces should be below usings.
<wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation"> | ||
<s:Boolean x:Key="/Default/CodeInspection/NamespaceProvider/NamespaceFoldersToSkip/=entities_005Cchannel_005Cmessage_005Cpoll/@EntryIndexedValue">True</s:Boolean></wpf:ResourceDictionary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider gitignoring this
fa990cf
to
6007a28
Compare
Just as a note, the pr in discord/discord-api-docs was merged in to main. This pr is ready to merge when #1835 is merged |
* Remove DotSettings file * Added DotSettings to gitignore * Fix namespace/usings ordering * Missed a namespace/using order * Added poll to discord message * Fix message builder check * Fix DiscordPoll Builder * Update other messages * Make DiscordPollLayoutType nullable for create payload * Add new poll intents * split add and remove in dispatch * Fix documentation * tag out intents causing error * Add json property to DiscordPollMedia Emoji * Move PollCreatePayload to DSharpPlus.Net.Abstractions * Fix build error * Use using for PollCreatePayload in DiscordMessageBuilder * Fix using order * Add Ending Poll and Get All Poll Answer Voters * Remove commented out intents (they are live) * Wow, poll permission! * Move expire to endpoints * Updated FULL_PERMS * Make expiry nullable. 'is marked as nullable to support non-expiring polls in the future' * fix build error * Pass DiscordPollBuilder along publicly
Summary
Adds support for polls
Notes
Resolves #1812