checks article #1818
Merged
checks article #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OoLunar
requested changes
Mar 31, 2024
OoLunar
approved these changes
Mar 31, 2024
|
why giggity? |
Giggity's cool |
Giggitybyte
requested changes
Apr 1, 2024
|
i love how noone is dared to use docfx links, because of how often they break |
|
like none of new command articles have them, which is actually great |
I was actually going to ask you to fix that on my PR |
|
i HATE docfx links, so, with all respect, no. |
|
we can surely live without them |
OoLunar
approved these changes
Apr 2, 2024
InFTord
approved these changes
Apr 2, 2024
OoLunar
pushed a commit
that referenced
this pull request
May 1, 2024
* add a few things to the checks article * address feedback * address PR feedback
akiraveliara
added a commit
that referenced
this pull request
May 2, 2024
* Rename `commands` to `commands_next` - `cd $(ProjectRoot)/docs/` - `rename "commands" "commands_next" images/commands*.png` - `grep --files-with-matches -r "commands.*\.png" . | xargs sed -i -r -e "s/commands(.*)\.png/commands\_next\1\.png/g"` - `mv commands commands_next` * Rename CommandsNext article id's from `articles.commands` to `articles.commands_next`. - `grep --files-with-matches -r "articles.commands." . | xargs sed -i "s/articles.commands./articles.commands_next./g"` * Add deprecation notice to CommandsNext articles * Rename Commands to CommandsNext in ToC * First article * Rename intro.md to introduction.md; Add custom argument converter article * Add custom command checks article * Add command error handling * Consistent naming * Fix context checks article name * Actually call `.AddCheck` * Autocomplete vs Choice Provider * Formatting * Deprecate `DSharpPlus.SlashCommands` * checks article (#1818) * add a few things to the checks article * address feedback * address PR feedback * Deprecate CommandsNext and SlashCommands * Remerge #1863, which mysteriously vanished * CommandsNext isn't fully replaceable yet, for lack of help and overloads - Aki * Document DI * Fix hyperlinks * CNext is unfortunately not obsoleted * Allow the extension to use it's own obsolete classes --------- Co-authored-by: Livia Silvercrown <61018569+akiraveliara@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates the article on checks