New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DS-4034] The "first few letters" search doesn't work with diacritics #7381
Comments
Is related to: DS-3996 |
adan.roman said: Its related with
|
tdonohue said: I've modified the title of the ticket, as it's not the main search box that isn't working (searching on names with diacritics works fine in DSpace). It's the "first few letters" search box (e.g. in the "jump to" section of Browse by Author) that doesn't seem to work with diacritics. Flagging this as "Needs volunteer" as I've verified it on demo.dspace.org (currently running 6.3) |
pablo.cda said: I've made some changes in PR:2310 that solved this issue. Bassicly, I've added StripDiacritics filter to the list of filters at OrderFormatText, in order to remove diacritic characters when indexing content. Also I' ve remove accents in DAO query at BrowseEngine in order when quering to Solr.
|
pablo.cda said: I didn't notice that someone have already solve this issue. Forget my last comment. |
alaw said: We have implemented PR 2310, which fixed issue DS-3996. However, with PR 2310 we are still experiencing the issue reported above with diacritics. We have also reported it in our GitHub project at Name with diacritic not searchable in Browse by Author. |
tonijpj said: Hello Anne Lawrence , DS-3996 describes a different issue, it is not related with diacritics and is fixed by a different PR (PR 2191). There are two similars PR to solve the problem related with diacritics: Both should work but I recommend to apply PR 2276 because it should also solve the issue |
alaw said: Toni, Thank you for the pointer. I look forward to trying PR 2276 and will report back how it goes. Anne |
667i said: Apologies if i am reading the proposed code changes wrong and this is already there, but there can be a simpler solution without the need to reindex. Instead of stripping diacritics, the prefix can be normalized the same way it's indexed, that is in dspace-api/src/main/java/org/dspace/discovery/SolrServiceImpl.java in resolveToSolrQuery() replace solrQuery.setFacetPrefix(field, facetFieldConfig.getPrefix()); with String normalizedPrefix = com.ibm.icu.text.Normalizer.normalize(facetFieldConfig.getPrefix(), com.ibm.icu.text.Normalizer.NFD); |
Closing, fixed by #2276 |
Imported from JIRA [DS-4034] created by adan.roman
It can be tested at http://demo.dspace.org/xmlui/browse?type=author searching an author with diacritic "Azcárate" for example. It return no results.
The text was updated successfully, but these errors were encountered: