Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest root range needs viewing hint to render properly in Mirador #8048

Closed
mspalti opened this issue Dec 1, 2021 · 0 comments · Fixed by #8049
Closed

Manifest root range needs viewing hint to render properly in Mirador #8048

mspalti opened this issue Dec 1, 2021 · 0 comments · Fixed by #8049
Assignees
Labels
bug integration: IIIF Related to International Image Interoperability Framework (IIIF) support
Milestone

Comments

@mspalti
Copy link
Member

mspalti commented Dec 1, 2021

Describe the bug
This bug was originally described in DSpace/dspace-angular#1395 because it causes a display issue in the Mirador viewer. However, the update is required on the REST side since it's caused by an omission in the IIIF manifest. I am recreating the issue here.

Currently, the table of contents view does not include the "top" viewing hint. From the docs:

[top viewing hint] Valid only for ranges. A Range with this viewingHint is the top-most node in a hierarchy of ranges that represents a structure to be rendered by the client to assist in navigation. For example, a table of contents within a paged object, major sections of a 3d object, the textual areas within a single scroll, and so forth.

Without this viewing hint, the Mirador viewer displays redundant information: an expandable "table of contents" element that includes all ranges and the same ranges listed separately.

To Reproduce
In the Mirador viewer, choose the index (in the left navigation panel) for this test item:

https://digitalcollections.willamette.edu/items/0a53d851-319b-4883-9d80-6bf0148ee2ed

Expected behavior
There should be a list of all ranges, with the redundant table of contents hidden.

The manifest should include the viewingHint:

{ @id: "https://digitalcollections.willamette.edu/server/iiif/0a53d851-319b-4883-9d80-6bf0148ee2ed/manifest/range/r0", @type: "sc:Range", label: "Table of Contents", viewingHint: "top", },

@mspalti mspalti added bug needs triage New issue needs triage and/or scheduling labels Dec 1, 2021
@mspalti mspalti added this to In Progress in DSpace 7.2 release Dec 1, 2021
@mspalti mspalti self-assigned this Dec 1, 2021
@tdonohue tdonohue added integration: IIIF Related to International Image Interoperability Framework (IIIF) support and removed needs triage New issue needs triage and/or scheduling labels Dec 2, 2021
@tdonohue tdonohue added this to the 7.2 milestone Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug integration: IIIF Related to International Image Interoperability Framework (IIIF) support
Projects
No open projects
DSpace 7.2 release
  
In Progress
Development

Successfully merging a pull request may close this issue.

2 participants