Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creative Commons Licence image does not appear on item page. #3002

Closed
priscilla-carmini opened this issue Jul 26, 2023 · 6 comments · Fixed by #3010
Closed

Creative Commons Licence image does not appear on item page. #3002

priscilla-carmini opened this issue Jul 26, 2023 · 6 comments · Fixed by #3010
Assignees
Milestone

Comments

@priscilla-carmini
Copy link

The Creative Commons licence image and link do not appear in item records in version 7.6. They do appear in version 6.4 (See image below). CC licence information appears in our metadata in 7.6, but not in the item record.

image

We would like the CC licence image to display on the item page. We would also like the image to link to the licence deed on the Creative Commons website.

@priscilla-carmini priscilla-carmini added bug needs triage New issue needs triage and/or scheduling labels Jul 26, 2023
@tdonohue tdonohue added integration: Creative Commons Related to CC license help wanted Needs a volunteer to claim to move forward good first issue This is a smaller ticket/bug that may be easier for new contributors low priority labels Jul 26, 2023
@Leano1998
Copy link
Contributor

Perhaps I'm wrong here, but isn't this more of a UI-issue? If the correct license information is there, we would only have to modify the item-page.component to display the corresponding license, for example by adding a new sub-component like item-licence.component.

@tdonohue
Copy link
Member

@Leano1998 : We generally don't mind which github repository a bug ticket is initially reported in.

That said, we can move this to the "DSpace/dspace-angular" github repository though once someone is able to investigate whether it definitely is a UI-issue. I suspect you may be correct, but I honestly don't know yet whether there need to also be improvements to the Backend (REST API), or if the only necessary changes are on the UI. So, this ticket is simply waiting for someone to investigate further & determine the proper next steps.

@autavares-dev
Copy link
Contributor

I have made a custom component to render the CC license image in the item page, however it is all done in the front-end. Can the issue be moved or should a new one be created in the dspace-angular repo in order to make a PR?

Example:
image

@tdonohue tdonohue transferred this issue from DSpace/DSpace May 3, 2024
@tdonohue
Copy link
Member

tdonohue commented May 3, 2024

@autavares-dev : This issue has now been transferred to dspace-angular. Technically, you are welcome to create a PR and link to the issue wherever the issue ticket exists, but I moved it to dspace-angular just to make it easier to locate :) Please feel free to create a PR if you have time/interest.

@tdonohue tdonohue removed the needs triage New issue needs triage and/or scheduling label May 3, 2024
@autavares-dev
Copy link
Contributor

autavares-dev commented May 3, 2024

@tdonohue I have code/PR ready for version 8.x.
But I see the issue is related to the DSpace 7.6.x Maintenance project.
Can I do the PR for the dspace-angular/main (8.x) branch or is it preferred to use the dspace-7_x branch?

@tdonohue
Copy link
Member

tdonohue commented May 3, 2024

@autavares-dev : You can create a PR for either version. It doesn't matter to us. For small PRs, we have an automatic process which will create a copy of the PR for the other branch (and usually it works well). If the automatic process doesn't work, we will do our best to port it to the other branch.

@tdonohue tdonohue removed help wanted Needs a volunteer to claim to move forward good first issue This is a smaller ticket/bug that may be easier for new contributors labels May 6, 2024
@tdonohue tdonohue added this to the 8.0 milestone May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

4 participants