DS-3636 Indexes and caching performance updates #1791
Conversation
| DROP INDEX IF EXISTS resourcepolicy_rptype_idx; | ||
| DROP INDEX IF EXISTS resourcepolicy_action_idx; | ||
| DROP INDEX IF EXISTS resourcepolicy_resource_type_id_idx; | ||
| DROP INDEX IF EXISTS resourcepolicy_resource_id_idx; |
There was a problem hiding this comment.
Please add a drop if exists for "resourcepolicy_type_id_idx"
| @@ -109,6 +108,37 @@ public boolean equals(Object obj) | |||
| } | |||
|
|
|||
| /** | |||
| * Create a new resource policy based on this one but copy it to another DSpace object | |||
There was a problem hiding this comment.
Please specify in the code comments why this is more efficient than just creating the record first and then setting all the field values (-> requires only insert statement vs 1 insert + 1 update).
| CREATE INDEX group2groupcache_parent_id_idx ON group2groupcache (parent_id); | ||
| CREATE INDEX group2groupcache_child_id_idx ON group2groupcache (child_id); | ||
| CREATE INDEX bundle2bitstream_bitstream_order_idx ON bundle2bitstream (bitstream_order); | ||
| CREATE INDEX metadatavalue_mf_place_idx ON metadatavalue (metadata_field_id, place); |
There was a problem hiding this comment.
There is already an index on metadata_field_id, so maybe we should just index "place".
|
Updated the indexes and code comments based on the feedback
|
|
I have only tested the indexes, but this pull request is a no-brainer for me as well. It greatly increases the performance of the XMLUI |
| @@ -19,5 +19,5 @@ begin | |||
| exception | |||
| when index_not_exists then null; | |||
| end; | |||
|
|
|||
| / | |||
There was a problem hiding this comment.
Is this change required to this old Migration script? Modifying a previous migration script, even by a single character will change the checksum of that script. That means that Flyway will no longer be able to validate this migration on databases that previously ran it. So, with this one character change, anyone running 5.7 or 5.8 will be required to run a dspace database repair in order to upgrade successfully. See https://wiki.duraspace.org/display/DSDOC6x/Database+Utilities
|
@tomdesair : just a reminder for you to dismiss your "requested changes" review if you are now satisfied with this PR. It looks to me like the changes you requested have now been made, but I hesitate to dismiss the review of any other Committer. |
tdonohue
added
bug
backend: Oracle
|
@kshepherd, should we consider this for 6.4? I haven't tried it yet but it seems relatively straightforward if something along similar lines hasn't already been applied, it might be worth porting to 7? @tdonohue |
It looks good - is there a dspace 6 port? |
|
Yeah, #1792 ...... but like I say, haven't tested this myself.... |
Pull Request for JIRA ticket:
https://jira.duraspace.org/browse/DS-3636
Put indexes on several widely searched columns + use some additional caching for performance improvements.