Edit Community/Collection - Assign Roles/Groups #105
Conversation
Edit Collection - Assign Roles/Groups
Edit Collection - Assign Roles/Groups
| * submittersGroup: the Collection Submitters group | ||
| * itemReadGroup: the Collection Default item READ rights group | ||
| * bitstreamReadGroup: the Collection Default bitstream READ rights group | ||
| * workflowGroups/<:workflow-role>: the Collection Workflow groups |
There was a problem hiding this comment.
should we splt the workflowGroups in two subpaths one for "collection" groups and one for general groups? in the configurable workflow indeed it is possible to define roles that are repository wide and not specific of a collection. Split them over separate subpath will make easier the management of permission as collection admins are not expected to be always allowed to edit "repository wide" roles.
In addition or in alternative, the defined roles should be exposed in the workflow definition and maybe here we can flag the "repository", "collection" and "item" roles
There was a problem hiding this comment.
For DSpace 6, the edit collection page only displays the workflow groups with the collection scope.
This is indeed because only general admins can manage the repository-wide workflow groups
It's indeed possible to extend this to expose collections/<:uuid>/collectionWorkflowGroups/<:workflow-role> and collections/<:uuid>/repositoryWorkflowGroups/<:workflow-role> where only general admins can access the latter.
But the collections/<:uuid>/repositoryWorkflowGroups/<:workflow-role> would work quite differently since it can't be created or deleted. It would only be present to display the group.
For that reason, I would personally prefer to use /api/config/workflowdefinitions/search/findByCollection?uuid=<:collection-uuid> and create an addition to expose the roles in the workflow definition or workflow step.
There was a problem hiding this comment.
The current approach (in this REST Contract) seems fine to me, along with what @benbosman notes. If we find a reason to enhance/change this Contract in the future we can do so then.
Edit Collection - Assign Roles/Groups
There was a problem hiding this comment.
👍 This looks good to me now, thanks @benbosman
As @abollini already gave this a +1, I'll merge this as-is. If we find the need for future enhancements, those can come in a future PR.
This includes support to edit the roles or groups of communities and collections.
It includes: