Authority control Rest contract #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abollini
approved these changes
Sep 5, 2019
There was a problem hiding this comment.
Thanks for the PR. I agree, the current implementation is not perfect and also the contract needs some clarification and cleanup. I suggest to approve it as is and me or @atarix83 will create a PR for the needed improvements soon
tdonohue
approved these changes
Sep 6, 2019
There was a problem hiding this comment.
👍 Looks good to me too. Thanks @benbosman. Merging, as this is now at +2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR documents the authority control implementation based on the current implementation
There are still bugs in the REST implementation, this PR is just making sure the current implementation is documented