Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS for a custom theme should be selected/loaded automatically. #1093

Closed
tdonohue opened this issue Apr 9, 2021 · 1 comment · Fixed by #1212
Closed

CSS for a custom theme should be selected/loaded automatically. #1093

tdonohue opened this issue Apr 9, 2021 · 1 comment · Fixed by #1212

Comments

@tdonohue
Copy link
Member

tdonohue commented Apr 9, 2021

Describe the bug
Discovered during the review of #1063 (comment)

When creating a custom theme (or even the "dspace" base theme), it is currently recommended to modify the src/index.html to reference your theme's CSS directly. See https://github.com/DSpace/dspace-angular/blob/main/src/index.html#L10

Expected behavior
Ideally, this CSS should be selected automatically and/or written into the file by webpack, for example https://medium.com/dailyjs/inserting-variables-into-html-and-javascript-with-webpack-80f33625edc6

This would make it easier to enable a custom theme just by modifying configuration (and no longer needing to touch the main index.html).

Tentatively scheduling for 7.0 as this seems like something we may want to clean up prior to final release.

@tdonohue tdonohue added this to the 7.0 milestone Apr 9, 2021
@tdonohue tdonohue added this to To Do in DSpace 7.0 (final) release via automation Apr 9, 2021
@tdonohue tdonohue mentioned this issue Apr 9, 2021
6 tasks
@artlowel
Copy link
Member

I created PR #1212 to fix this issue and #1134. It took 2 hours

@tdonohue tdonohue added e/1 Estimate in hours and removed Estimate TBD labels May 27, 2021
@tdonohue tdonohue moved this from To Do to In Progress in DSpace 7.0 (final) release May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants