Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging in should also trigger a refresh #712

Closed
artlowel opened this issue Jun 22, 2020 · 0 comments · Fixed by #856
Closed

Logging in should also trigger a refresh #712

artlowel opened this issue Jun 22, 2020 · 0 comments · Fixed by #856
Labels
Milestone

Comments

@artlowel
Copy link
Member

When logging in, we should also do a refresh, the same way we do when logging out. Because rest requests that were made while anonymous may have different results when you're logged in.

E.g. the bitstream of this item is private, so if you go to this page anonymously you don't see a bitstream.

If you log in using the menu in the header you still don't see the bitstream. Only after you refresh do you see it.

While this is one small example, with the support for features and authorizations in the UI a lot more of these will start to surface. The most foolproof way of dealing with this is refreshing whenever the active user changes in my opinion.

Note: I just created another issue (#711) involving redirects after logging in. Perhaps fixing this issue can also solve that one.

@artlowel artlowel added the bug label Jun 22, 2020
@tdonohue tdonohue added the authentication: general general authentication issues label Jun 24, 2020
@tdonohue tdonohue added this to To Do in DSpace 7 Beta 5 via automation Jul 17, 2020
DSpace 7 Beta 5 automation moved this from To Do to Done Sep 17, 2020
@tdonohue tdonohue added this to the 7.0beta4 milestone Oct 8, 2020
@tdonohue tdonohue removed this from Done in DSpace 7 Beta 5 Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants