Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch some bugs when bad mesh files are used in dtocean-wec #14

Merged
merged 14 commits into from
Sep 12, 2022

Conversation

H0R5E
Copy link
Member

@H0R5E H0R5E commented Sep 8, 2022

  • Renamed dtocean_wec.submodule.utils.mesh_util module as dtocean_wec.submodule.utils.mesh and refactored.
  • Fixed bugs that occur if opening wrong type of mesh file in dtocean-wec.

@AppVeyorBot
Copy link

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #14 (e898730) into master (25bc9dd) will increase coverage by 1.81%.
The diff coverage is 96.33%.

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   38.47%   40.28%   +1.81%     
==========================================
  Files          93       93              
  Lines       11742    11656      -86     
  Branches     1429     1415      -14     
==========================================
+ Hits         4518     4696     +178     
+ Misses       7019     6754     -265     
- Partials      205      206       +1     
Impacted Files Coverage Δ
dtocean_wec/tab2.py 19.60% <0.00%> (ø)
dtocean_wec/utils/mesh_class.py 6.08% <50.00%> (+0.46%) ⬆️
dtocean_wec/submodule/nemoh_run.py 19.88% <85.00%> (+8.77%) ⬆️
dtocean_wec/submodule/utils/mesh.py 98.96% <98.96%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@H0R5E H0R5E merged commit a54366b into DTOcean:master Sep 12, 2022
@H0R5E H0R5E deleted the bad_mesh branch September 12, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants