Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS refactoring #434

Merged
merged 1 commit into from
Feb 19, 2024
Merged

TS refactoring #434

merged 1 commit into from
Feb 19, 2024

Conversation

sebastien-comeau
Copy link
Contributor

@sebastien-comeau sebastien-comeau commented Feb 19, 2024

Description

  • Set eslint rule import/consistent-type-specifier-style to error with prefer-top-level option
  • Remove unused @gregory-j-baker types from type.d.ts file
  • Move RouteHandleData interface out of type.d.ts file since it is not recommended. type.d.ts file should only be used for type augmentation when really needed.
  • Apply prettier format fix

Related Azure Boards Work Items

Screenshots (if applicable)

Checklist

  • I have tested the changes locally
  • I have updated the documentation if necessary
  • I have added/updated tests that prove my fix is effective or that my feature works
  • I have checked that my code follows the project's coding style by running npm run format:check
  • I have checked that my code contains no linting errors by running npm run lint
  • I have checked that my code contains no type errors by running npm run typecheck
  • I have checked that all unit tests pass by running npm run test:unit -- run
  • I have checked that all e2e tests pass by running npm run test:e2e

Test Instructions

Additional Notes

@sebastien-comeau sebastien-comeau enabled auto-merge (squash) February 19, 2024 17:48
@sebastien-comeau sebastien-comeau merged commit c657fb4 into main Feb 19, 2024
1 check passed
@sebastien-comeau sebastien-comeau deleted the seb/ts-refactoring branch February 19, 2024 18:17
CanadianPhilipBarkow pushed a commit that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants