Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix/folderPicker][taier-ui]fix folderPicker with workflow #797

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

mortalYoung
Copy link
Collaborator

@mortalYoung mortalYoung commented Oct 14, 2022

简介

  • 修复存储位置在某些情况下会出现工作流的问题

Related Issues

Closed #787

@mortalYoung mortalYoung added the bug Something isn't working label Oct 14, 2022
@mortalYoung mortalYoung self-assigned this Oct 14, 2022
Copy link
Contributor

@StrangeXin StrangeXin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

1.2版本里type有flow类型,1.3去掉了么? 如果没去掉,这里判断还是有问题

@mortalYoung
Copy link
Collaborator Author

image

1.2版本里type有flow类型,1.3去掉了么? 如果没去掉,这里判断还是有问题

1.3 的版本里没有去掉,原先的逻辑是通过服务端给的数据类型里的 type 来判断是否是 folder,就是你红框这里的数据,但是这个是保险。
目前的逻辑是改造成通过判断 treeNode.fileType

@mortalYoung
Copy link
Collaborator Author

目前来说,只有服务端的 type 是 folder 和 catalogue 的时候,fileType 字段会是 folder,其余情况都是 file。folderPicker 下的逻辑也和左侧目录树保持一致。fileType 的赋值可以参考 catalogueService

@mortalYoung mortalYoung merged commit 92a8f73 into 1.3_beta Oct 19, 2022
@mortalYoung mortalYoung deleted the fix/folderPicker branch October 19, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
v1.3.0
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants