Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: support mysql task #925

Merged
merged 5 commits into from
Dec 5, 2022
Merged

Conversation

chyueyi
Copy link
Contributor

@chyueyi chyueyi commented Nov 30, 2022

增加MySQL任务类型

@chyueyi chyueyi changed the title Feature mysql task Feature: suport mysql task Nov 30, 2022
@vainhope
Copy link
Collaborator

需要在sql目录新增1.3.1的目录文件 1.3.1_increment.sql
在1.3.1里补充 mysql任务的 sql脚本

@chyueyi
Copy link
Contributor Author

chyueyi commented Nov 30, 2022

需要在sql目录新增1.3.1的目录文件 1.3.1_increment.sql 在1.3.1里补充 mysql任务的 sql脚本

已增加

@mortalYoung
Copy link
Collaborator

应该还有一个编辑器高亮没做

/**
* 把 taskType 映射到 taskLanguage
*/
export function mappingTaskTypeToLanguage(taskType: TASK_TYPE_ENUM) {
switch (taskType) {
case TASK_TYPE_ENUM.SPARK_SQL:
case TASK_TYPE_ENUM.DORIS:
case TASK_TYPE_ENUM.CLICKHOUSE:
return TASK_LANGUAGE.SPARKSQL;
case TASK_TYPE_ENUM.HIVE_SQL:
return TASK_LANGUAGE.HIVESQL;
case TASK_TYPE_ENUM.SQL:
return TASK_LANGUAGE.FLINKSQL;
case TASK_TYPE_ENUM.OCEANBASE:
return TASK_LANGUAGE.SQL;
case TASK_TYPE_ENUM.SYNC:
case TASK_TYPE_ENUM.DATA_ACQUISITION:
return TASK_LANGUAGE.JSON;
case TASK_TYPE_ENUM.PYTHON:
return TASK_LANGUAGE.PYTHON;
case TASK_TYPE_ENUM.SHELL:
return TASK_LANGUAGE.SHELL;
default:
return TASK_LANGUAGE.SQL;
}
}

这里有一个把任务类型映射到 Mysql 的语法上

switch (taskType) {
		....
+             case TASK_TYPE_ENUM.MYSQL:
+                       return TASK_LANGUAGE.MYSQL
		default:
			return TASK_LANGUAGE.SQL;
	}

@mortalYoung mortalYoung changed the title Feature: suport mysql task Feature: support mysql task Dec 2, 2022
@chyueyi
Copy link
Contributor Author

chyueyi commented Dec 2, 2022

应该还有一个编辑器高亮没做

/**
* 把 taskType 映射到 taskLanguage
*/
export function mappingTaskTypeToLanguage(taskType: TASK_TYPE_ENUM) {
switch (taskType) {
case TASK_TYPE_ENUM.SPARK_SQL:
case TASK_TYPE_ENUM.DORIS:
case TASK_TYPE_ENUM.CLICKHOUSE:
return TASK_LANGUAGE.SPARKSQL;
case TASK_TYPE_ENUM.HIVE_SQL:
return TASK_LANGUAGE.HIVESQL;
case TASK_TYPE_ENUM.SQL:
return TASK_LANGUAGE.FLINKSQL;
case TASK_TYPE_ENUM.OCEANBASE:
return TASK_LANGUAGE.SQL;
case TASK_TYPE_ENUM.SYNC:
case TASK_TYPE_ENUM.DATA_ACQUISITION:
return TASK_LANGUAGE.JSON;
case TASK_TYPE_ENUM.PYTHON:
return TASK_LANGUAGE.PYTHON;
case TASK_TYPE_ENUM.SHELL:
return TASK_LANGUAGE.SHELL;
default:
return TASK_LANGUAGE.SQL;
}
}

这里有一个把任务类型映射到 Mysql 的语法上

switch (taskType) {
		....
+             case TASK_TYPE_ENUM.MYSQL:
+                       return TASK_LANGUAGE.MYSQL
		default:
			return TASK_LANGUAGE.SQL;
	}

已增加

@chyueyi chyueyi closed this Dec 2, 2022
@chyueyi chyueyi reopened this Dec 2, 2022
Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@@ -262,6 +262,7 @@ const updateTaskVariables = debounce((tab: molecule.model.IEditorTab<any>) => {
case TASK_TYPE_ENUM.DORIS:
case TASK_TYPE_ENUM.CLICKHOUSE:
case TASK_TYPE_ENUM.SQL:
case TASK_TYPE_ENUM.MYSQL:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vainhope vainhope merged commit 5da5aa3 into DTStack:master Dec 5, 2022
@chyueyi chyueyi deleted the feature-mysql branch December 7, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants