Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] BaseRichOutputFormat 抛出NoRestartException 可能会导致任务无法正常停止 #1501

Closed
2 of 3 tasks
zhourui999 opened this issue Feb 14, 2023 · 3 comments · Fixed by #1507
Closed
2 of 3 tasks
Labels
bug Something isn't working

Comments

@zhourui999
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

image

timerWriteException 这个变量的赋值只会在定时任务失败后,如果是preCommit调用则会导致抛出的NoRestartException被吃掉

What you expected to happen

任务停止

How to reproduce

关闭定时提交的任务initTimingSubmitTask()

Anything else

No response

Version

master

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@zhourui999 zhourui999 added the bug Something isn't working label Feb 14, 2023
@zoudaokoulife
Copy link
Contributor

这个地方确实是一个bug;
image

这个地方不应该只是打印日志;

@zoudaokoulife
Copy link
Contributor

@zhourui999 你要修复下这个bug吗?

@zhourui999
Copy link
Contributor Author

zhourui999 commented Feb 16, 2023

image

建议加上 checkTimerWriteException(); 要不然脏数据产生有时也不能立马停止。目前是产生一个脏数据后,需要后续继续有数据过来才能停止程序

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants