Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix-#1195]change the code position to support oracle nchar、nvarch… #1196

Merged
merged 3 commits into from
Aug 30, 2022
Merged

[hotfix-#1195]change the code position to support oracle nchar、nvarch… #1196

merged 3 commits into from
Aug 30, 2022

Conversation

momisabuilder
Copy link
Contributor

[hotfix-#1195]change the code position to support oracle nchar、nvarchar2 chinese value

chaozwn
chaozwn reviewed Aug 29, 2022
View reviewed changes
Copy link
Member

@chaozwn chaozwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use org.apache.commons.lang3.StringEscapeUtils#unescapeJava instead of create a method unicodeToString by yourself.

@FlechazoW FlechazoW linked an issue Aug 30, 2022 that may be closed by this pull request
[Bug] [connector] [oraclelogminer] oralce do not support nchar，nvarchar2 chinese value #1195
Closed
3 tasks
@FlechazoW FlechazoW added this to In progress in v1.12.6 via automation Aug 30, 2022
@FlechazoW FlechazoW added the bug Something isn't working label Aug 30, 2022
@FlechazoW FlechazoW merged commit 509d7b2 into DTStack:master Aug 30, 2022
v1.12.6 automation moved this from In progress to Done Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaozwn chaozwn chaozwn left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
v1.12.6
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] [connector] [oraclelogminer] oralce do not support nchar，nvarchar2 chinese value
3 participants
@momisabuilder @chaozwn @FlechazoW