[feat-#1204][e2e] Add Oracle Logminer E2E Test. #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
FlechazoW
reviewed
Aug 31, 2022
| return this; | ||
| } | ||
|
|
||
| public LaunchCommandBuilder withAddJar(List<String> path) { | ||
| commands.add("-addjar"); | ||
| commands.add(GsonUtil.GSON.toJson(path)); | ||
| commands.add(new GsonBuilder().create().toJson(path)); |
There was a problem hiding this comment.
Why use new Gson rather than GsonUtil.GSON?
There was a problem hiding this comment.
At this time, because GsonUtil uses prettyjson by default, when using the shell to submit, we cannot appear \r\n json data.
There was a problem hiding this comment.
The json we use must be one line of data.
FlechazoW
reviewed
Aug 31, 2022
| @@ -63,13 +70,13 @@ public LaunchCommandBuilder withFlinkConfDir(String flinkConfDir) { | |||
|
|
|||
| public LaunchCommandBuilder withFlinkCustomConf(Map<String, Object> properties) { | |||
| commands.add("-confProp"); | |||
| commands.add(GsonUtil.GSON.toJson(properties)); | |||
| commands.add(new GsonBuilder().create().toJson(properties)); | |||
There was a problem hiding this comment.
Why use new Gson rather than GsonUtil.GSON?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Which issue you fix
Fixes # (issue).
Checklist: