Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat-#1235][e2e]add emqx container #1236

Merged
merged 7 commits into from
Sep 12, 2022
Merged

[feat-#1235][e2e]add emqx container #1236

merged 7 commits into from
Sep 12, 2022

Conversation

mggger
Copy link
Contributor

@mggger mggger commented Sep 8, 2022 •
edited

Purpose of this pull request

add emqx container

Which issue you fix

Fixes #1235 .

Checklist:

  • I have executed the 'mvn spotless:apply' command to format my code.
  • I have a meaningful commit message (including the issue id, the template of commit message is '[label-type-#issue-id][fixed-module] a meaningful commit message.')
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have checked my code and corrected any misspellings.
  • My commit is only one. (If there are multiple commits, you can use 'git squash' to compress multiple commits into one.)

FlechazoW
FlechazoW reviewed Sep 8, 2022
View reviewed changes
chunjun-e2e/src/test/java/com/dtstack/chunjun/connector/containers/emqx/EmqxContainer.java
@@ -0,0 +1,41 @@
package com.dtstack.chunjun.connector.containers.emqx;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add license please.

FlechazoW
FlechazoW reviewed Sep 8, 2022
View reviewed changes
chunjun-e2e/src/test/java/com/dtstack/chunjun/connector/containers/emqx/EmqxContainer.java Outdated
/**
* @author kungen@dtstack.com
* @Date 2022/9/7
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the company info.

FlechazoW
FlechazoW reviewed Sep 8, 2022
View reviewed changes
...-e2e/src/test/java/com/dtstack/chunjun/connector/test/standalone/emqx/EmqxSyncE2eITCase.java
@@ -0,0 +1,68 @@
package com.dtstack.chunjun.connector.test.standalone.emqx;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add license please.

FlechazoW
FlechazoW reviewed Sep 8, 2022
View reviewed changes
...-e2e/src/test/java/com/dtstack/chunjun/connector/test/standalone/emqx/EmqxSyncE2eITCase.java Outdated
/**
* @author kungen@dtstack.com
* @Date 2022/9/7
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the company info.

@FlechazoW FlechazoW mentioned this pull request Sep 8, 2022
Open
@FlechazoW FlechazoW merged commit 874f86c into DTStack:master Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlechazoW FlechazoW FlechazoW left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature][e2e] add emqx container
2 participants
@mggger @FlechazoW