Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] kudu:GenericRowData can not cast ColumnRowData #1277

Merged
merged 4 commits into from
Sep 28, 2022

Conversation

JaryZhen
Copy link
Contributor

@JaryZhen JaryZhen commented Sep 21, 2022

Purpose of this pull request

Which issue you fix

Fixes # (issue).

Checklist:

  • I have executed the 'mvn spotless:apply' command to format my code.
  • I have a meaningful commit message (including the issue id, the template of commit message is '[label-type-#issue-id][fixed-module] a meaningful commit message.')
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have checked my code and corrected any misspellings.
  • My commit is only one. (If there are multiple commits, you can use 'git squash' to compress multiple commits into one.)

@JaryZhen
Copy link
Contributor Author

Related to
#1276
#1275

@FlechazoW
Copy link
Member

Is the pr fix two issues?

@JaryZhen
Copy link
Contributor Author

yes

@FlechazoW
Copy link
Member

We will accept the change of this pr, but you need to split this pr into two, one pr corresponds to the solution of one issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants