Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat-#1293][chunjun-connector-hdfs] add assembleFieldProps for hdfs-connector #1294

Merged
merged 2 commits into from
Oct 9, 2022
Merged

[feat-#1293][chunjun-connector-hdfs] add assembleFieldProps for hdfs-connector #1294

merged 2 commits into from
Oct 9, 2022

Conversation

liumengkai
Copy link
Contributor

@liumengkai liumengkai commented Oct 9, 2022

Purpose of this pull request

add assembleFieldProps for hdfs-connector

Which issue you fix

#1293

Checklist:

  • I have executed the 'mvn spotless:apply' command to format my code.
  • I have a meaningful commit message (including the issue id, the template of commit message is '[label-type-#issue-id][fixed-module] a meaningful commit message.')
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have checked my code and corrected any misspellings.
  • My commit is only one. (If there are multiple commits, you can use 'git squash' to compress multiple commits into one.)

@liumengkai
Copy link
Contributor Author

I realize hdfs-connector still has orc,parqut file type need to do this ,I will add them

…connector during column converter orc&parquet&text
@FlechazoW
Copy link
Member

+1

@Paddy0523
Copy link
Contributor

LGTM

@FlechazoW FlechazoW merged commit a2f6b22 into DTStack:master Oct 9, 2022
lyzeo pushed a commit to lyzeo/chunjun that referenced this pull request Oct 19, 2022
…r hdfs-connector (DTStack#1294)

* [feat-DTStack#1293][chunjun-connector-hdfs] add assembleFieldProps for hdfs connector during column converter

* [feat-DTStack#1293][chunjun-connector-hdfs] add assembleFieldProps for hdfs connector during column converter orc&parquet&text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][connector-hdfs] add assembleFieldProps for hdfs connector during column converter
3 participants