Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] [chunjun-connector-stream,chunjun-connector-elasticsearch-base… #1364

Merged
merged 5 commits into from
Oct 31, 2022
Merged

Conversation

gaoasi
Copy link
Contributor

@gaoasi gaoasi commented Oct 28, 2022

…,chunjun-connector-jdbs-base] enrich sql type data type,add [ROW,ARRAY,MAP,MULTISET] data type,only support sql type

[test] [chunjun-examples/sql/[stream,elasticsearch7,postgresql], add test file test [ROW,ARRAY,MAP] data type

Purpose of this pull request

enrich sql type data type,add [ROW,ARRAY,MAP,MULTISET] data type,only support sql type

Which issue you fix

Fixes # (issue).

Checklist:

  • I have executed the 'mvn spotless:apply' command to format my code.
  • I have a meaningful commit message (including the issue id, the template of commit message is '[label-type-#issue-id][fixed-module] a meaningful commit message.')
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have checked my code and corrected any misspellings.
  • My commit is only one. (If there are multiple commits, you can use 'git squash' to compress multiple commits into one.)

高阿四 and others added 2 commits October 28, 2022 19:03
…,chunjun-connector-jdbs-base] enrich sql type data type,add [ROW,ARRAY,MAP,MULTISET] data type,only support sql type

[test] [chunjun-examples/sql/[stream,elasticsearch7,postgresql], add test file test [ROW,ARRAY,MAP] data type
As title.

Signed-off-by: Wey Gu <weyl.gu@gmail.com>
@FlechazoW
Copy link
Member

CC. @PaddyMelody @chaozwn @yanghuaiGit @mggger @ll076110

高阿四 added 2 commits October 31, 2022 14:57
…,chunjun-connector-jdbs-base] enrich sql type data type,add [ROW,ARRAY,MAP,MULTISET] data type,only support sql type

[test] [chunjun-examples/sql/[stream,elasticsearch7,postgresql], add test file test [ROW,ARRAY,MAP] data type
@mggger
Copy link
Contributor

mggger commented Oct 31, 2022

LGTM

� Conflicts:
�	chunjun-core/src/main/java/com/dtstack/chunjun/util/ExternalDataUtil.java
@FlechazoW FlechazoW merged commit 3958a70 into DTStack:master Oct 31, 2022
CREATE TABLE test
(
id bigint,
deployment_pictures ARRAY<varchar>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to run the script, but a warning came up.

2022-10-31 15:20:03,049 - 8088 WARN  [main] com.dtstack.chunjun.connector.jdbc.converter.JdbcRowConverter:Unsupported type: Map<String, String>
2022-10-31 15:20:03,056 - 8095 WARN  [main] com.dtstack.chunjun.connector.jdbc.converter.JdbcRowConverter:Unsupported type: Row(Name: String, Contact: String)

Do you know why

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exclude nested data types, such as ROW(id int,data ROW(id string))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because TypeConversions dose not support nested data type convert
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants