Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][Connector][FTP] Reactor "ftp-connector". #1367

Merged
merged 3 commits into from
Nov 4, 2022
Merged

[Improve][Connector][FTP] Reactor "ftp-connector". #1367

merged 3 commits into from
Nov 4, 2022

Conversation

FlechazoW
Copy link
Member

supports ftp read big file and release connection in session mode.

Purpose of this pull request

Which issue you fix

None

Checklist:

  • I have executed the 'mvn spotless:apply' command to format my code.
  • I have a meaningful commit message (including the issue id, the template of commit message is '[label-type-#issue-id][fixed-module] a meaningful commit message.')
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have checked my code and corrected any misspellings.
  • My commit is only one. (If there are multiple commits, you can use 'git squash' to compress multiple commits into one.)

mggger
mggger reviewed Nov 4, 2022
View reviewed changes
...jun-connector-ftp/src/main/java/com/dtstack/chunjun/connector/ftp/source/FtpInputFormat.java Outdated Show resolved Hide resolved
...njun-connector-ftp/src/main/java/com/dtstack/chunjun/connector/ftp/source/FtpFileReader.java Outdated Show resolved Hide resolved
...njun-connector-ftp/src/main/java/com/dtstack/chunjun/connector/ftp/source/FtpFileReader.java Outdated Show resolved Hide resolved
...njun-connector-ftp/src/main/java/com/dtstack/chunjun/connector/ftp/source/FtpFileReader.java Outdated Show resolved Hide resolved
...njun-connector-ftp/src/main/java/com/dtstack/chunjun/connector/ftp/sink/FtpOutputFormat.java Show resolved Hide resolved
...rs/chunjun-connector-ftp/src/main/java/com/dtstack/chunjun/connector/ftp/conf/FtpConfig.java Show resolved Hide resolved
...rs/chunjun-connector-ftp/src/main/java/com/dtstack/chunjun/connector/ftp/conf/FtpConfig.java Outdated Show resolved Hide resolved
...rs/chunjun-connector-ftp/src/main/java/com/dtstack/chunjun/connector/ftp/conf/FtpConfig.java Outdated Show resolved Hide resolved
...rs/chunjun-connector-ftp/src/main/java/com/dtstack/chunjun/connector/ftp/conf/FtpConfig.java Outdated Show resolved Hide resolved
...jun-connector-ftp/src/main/java/com/dtstack/chunjun/connector/ftp/source/FtpInputFormat.java Outdated Show resolved Hide resolved
@FlechazoW
[Improve][Connector][FTP] Reactor "ftp-connector", supports ftp read …
cf6b758 
…bigfile and release connection in session mode.
mggger
mggger approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@mggger mggger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FlechazoW FlechazoW merged commit 2b088ad into DTStack:master Nov 4, 2022
@FlechazoW FlechazoW deleted the master_ftp branch November 4, 2022 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mggger mggger mggger approved these changes

@ll076110 ll076110 ll076110 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FlechazoW @mggger @ll076110