feat: develop modal #401

mortalYoung · 2023-11-01T12:39:34Z

简介

新增 Modal 组件

Changes

和 Ant Design 的区别在于，更符合袋鼠云的设计规范

限制最大高度
尺寸对应的宽度
支持 banner 属性

Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.2. - [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md) - [Commits](browserify/browserify-sign@v4.2.1...v4.2.2) --- updated-dependencies: - dependency-name: browserify-sign dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: import highlight core only * feat: improve Hljs types

Co-authored-by: zhaoge <>

mortalYoung · 2023-11-02T12:17:54Z

Previewer

mumiao · 2023-11-03T02:20:00Z

Previewer

banner 和size属性，组件文档没有出现

mumiao · 2023-11-03T02:24:29Z

这个组件是基于之前Modal.Form改造而来的，你link到资产那边测试看看，对于原先组件有没有影响，再Review一下 @LuckyFBB

mortalYoung · 2023-11-03T08:14:39Z

这个组件是基于之前Modal.Form改造而来的，你link到资产那边测试看看，对于原先组件有没有影响，再Review一下 @LuckyFBB

不是的理解错了文档更新了再看一样文档呗

src/modal/index.tsx

liuxy0551 · 2023-11-07T03:14:30Z

src/modal/components/modal/index.tsx

+
+export interface IModalProps extends ModalProps {
+    size?: 'small' | 'default' | 'large';
+    banner?: AlertProps['message'] | Omit<AlertProps, 'banner'>;


为啥将 alert 改名为了 banner，看到那个样式第一眼就是 alert 的组件，也方便去看 AlertProps

回头看看，感觉叫alert会不会确实好点

因为从设计师的角度来说，这个叫做 banner，并且基本上是用 alert 的 banner 模式，所以我这里直接叫 banner 我认为会更好一些。

mumiao · 2023-11-07T12:14:20Z

+1

* fix(useList): initialParams suppport function type (#393) * build(deps-dev): bump browserify-sign from 4.2.1 to 4.2.2 (#399) Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.2. - [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md) - [Commits](browserify/browserify-sign@v4.2.1...v4.2.2) --- updated-dependencies: - dependency-name: browserify-sign dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: import highlight core only (#402) * feat: import highlight core only * feat: improve Hljs types * feat: add sideEffects field to improve treeShaking (#403) * fix: upgrade SpreadSheet component for can be binded ref (#404) Co-authored-by: zhaoge <> * feat: add search component on sidebar (#405) * feat: develop modal * feat(Modal): improve banner check * test: add test cases --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hayden <hayden9653@gmail.com> Co-authored-by: XCynthia <942884029@qq.com>

* Feat update slide pane (#385) * feat: update slidePane for mask * feat(slidepane): add tabs for slidepane * feat(slidepane): update motion for slidePane * feat(slidepane): update ts error and style * feat(slidepane): update doc and unit test * fix(slidepane): update props name and edit showMask to mask * fix(unittest): update unit test * fix(slidepane): update ts type * feat: add tinyTag (#396) * feat: add tinyTag * feat: support HTMLSpanElement's Attributes and color * docs: update docs * Feat image (#395) * feat(intersectionobserver): add IntersectionObserver hook * feat(intersectionobserver): update IntersectionObserver unit test * feat(useintersectionobserver): use ref and add freezeOnceVisible * feat(useintersectionobserver): update test unit * feat(image): add image component * feat(image): update review comment and mock window.Image * feat(image): add image test * feat(contentlayout): add contentLayout (#384) * feat(contentlayout): add contentLayout * feat(contentlayout): update contentLayout export table/header * feat(contentlayout): update contentLayout info * feat: update contentLayout md * feat(contengtlayout): update contentLayout md * feat(contentlayout): update some props * feat: develop modal (#401) * fix(useList): initialParams suppport function type (#393) * build(deps-dev): bump browserify-sign from 4.2.1 to 4.2.2 (#399) Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.2. - [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md) - [Commits](browserify/browserify-sign@v4.2.1...v4.2.2) --- updated-dependencies: - dependency-name: browserify-sign dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: import highlight core only (#402) * feat: import highlight core only * feat: improve Hljs types * feat: add sideEffects field to improve treeShaking (#403) * fix: upgrade SpreadSheet component for can be binded ref (#404) Co-authored-by: zhaoge <> * feat: add search component on sidebar (#405) * feat: develop modal * feat(Modal): improve banner check * test: add test cases --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hayden <hayden9653@gmail.com> Co-authored-by: XCynthia <942884029@qq.com> * Feat utils (#409) * build(deps-dev): bump browserify-sign from 4.2.1 to 4.2.2 (#399) Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.2. - [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md) - [Commits](browserify/browserify-sign@v4.2.1...v4.2.2) --- updated-dependencies: - dependency-name: browserify-sign dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: remove inner utils and add dt-utils dependence * fix: fix pnpm-lock antd/icon patch version --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jialan <jialan@dtstack.com> * feat: new component Catalogue in v5 (#389) * feat(Catalogue): new component, catalogue initial * chore(Catalogue): lint * docs: update demo docs * feat: clear searchStr when close search * docs: update demo docs * feat: add defaultStatus & onStatusChange props in Catalogue.DtTree * chore: rename dtTree、dtTreeSelect to Tree、TreeSelect * chore: update demos and docs * chore: treeTit prop exchange to treeTitle --------- Co-authored-by: dilu <dilu@dtstack.com> * feat(filterrules): add FilterRules (#407) * feat(filterrules): add FilterRules * feat(filterrules): update some example * feat(filterrules): add some example and props type and use weakMap to save height/lineheight * feat(filterrules): update ts and add comment * feat(filterrules): update FilterRules props and formitem name * feat(filterrules): add comment and unit test * feat(filterrrules): update contants file and style * test(filterrules): update test unit --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: 霜序 <38368040+LuckyFBB@users.noreply.github.com> Co-authored-by: 野迂迂 <yangwei1@outlook.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hayden <hayden9653@gmail.com> Co-authored-by: XCynthia <942884029@qq.com> Co-authored-by: JackWang032 <64318393+JackWang032@users.noreply.github.com> Co-authored-by: jialan <jialan@dtstack.com> Co-authored-by: Frank <scofield90.email@gmail.com> Co-authored-by: dilu <dilu@dtstack.com>

* fix(useList): initialParams suppport function type (#393) * build(deps-dev): bump browserify-sign from 4.2.1 to 4.2.2 (#399) Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.2. - [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md) - [Commits](browserify/browserify-sign@v4.2.1...v4.2.2) --- updated-dependencies: - dependency-name: browserify-sign dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: import highlight core only (#402) * feat: import highlight core only * feat: improve Hljs types * feat: add sideEffects field to improve treeShaking (#403) * fix: upgrade SpreadSheet component for can be binded ref (#404) Co-authored-by: zhaoge <> * feat: add search component on sidebar (#405) * feat: develop modal * feat(Modal): improve banner check * test: add test cases --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hayden <hayden9653@gmail.com> Co-authored-by: XCynthia <942884029@qq.com>

fix(useList): initialParams suppport function type (DTStack#393)

d02017d

mumiao self-requested a review November 2, 2023 01:59

dependabot bot and others added 4 commits November 2, 2023 10:02

feat: import highlight core only (DTStack#402)

b283772

* feat: import highlight core only * feat: improve Hljs types

feat: add sideEffects field to improve treeShaking (DTStack#403)

1faa376

fix: upgrade SpreadSheet component for can be binded ref (DTStack#404)

361486c

Co-authored-by: zhaoge <>

mortalYoung changed the title ~~WIP: feat: develop modal~~ feat: develop modal Nov 2, 2023

mortalYoung force-pushed the feat/modal branch from 3d33479 to f13d8f9 Compare November 2, 2023 12:19

mortalYoung requested a review from liuxy0551 November 2, 2023 12:19

mumiao requested review from LuckyFBB and removed request for liuxy0551 November 3, 2023 02:24

mortalYoung added 4 commits November 3, 2023 10:41

feat: add search component on sidebar (DTStack#405)

2723267

feat: develop modal

2efab3b

feat(Modal): improve banner check

36b925e

test: add test cases

2950975

mortalYoung force-pushed the feat/modal branch from f13d8f9 to 2950975 Compare November 3, 2023 08:09

mumiao reviewed Nov 3, 2023

View reviewed changes

src/modal/index.tsx Show resolved Hide resolved

mumiao changed the base branch from master to feat_5.x November 6, 2023 05:48

mumiao approved these changes Nov 6, 2023

View reviewed changes

mumiao added this to the Next Version(5.0.0） milestone Nov 6, 2023

liuxy0551 reviewed Nov 7, 2023

View reviewed changes

mumiao merged commit 737530e into DTStack:feat_5.x Nov 7, 2023
1 check passed

mumiao mentioned this pull request Nov 7, 2023

dt-react-component 5.0 TODO List #386

Closed

8 tasks

mortalYoung deleted the feat/modal branch November 14, 2023 03:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: develop modal #401

feat: develop modal #401

mortalYoung commented Nov 1, 2023

mortalYoung commented Nov 2, 2023

mumiao commented Nov 3, 2023 •

edited

Loading

mumiao commented Nov 3, 2023

mortalYoung commented Nov 3, 2023

liuxy0551 Nov 7, 2023

mumiao Nov 7, 2023

mortalYoung Nov 7, 2023

mumiao commented Nov 7, 2023

feat: develop modal #401

feat: develop modal #401

Conversation

mortalYoung commented Nov 1, 2023

简介

Changes

mortalYoung commented Nov 2, 2023

mumiao commented Nov 3, 2023 • edited Loading

mumiao commented Nov 3, 2023

mortalYoung commented Nov 3, 2023

liuxy0551 Nov 7, 2023

Choose a reason for hiding this comment

mumiao Nov 7, 2023

Choose a reason for hiding this comment

mortalYoung Nov 7, 2023

Choose a reason for hiding this comment

mumiao commented Nov 7, 2023

mumiao commented Nov 3, 2023 •

edited

Loading