Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update slide pane #385

Merged
merged 8 commits into from
Sep 26, 2023
Merged

feat: update slide pane #385

merged 8 commits into from
Sep 26, 2023

Conversation

LuckyFBB
Copy link
Collaborator

@LuckyFBB LuckyFBB commented Sep 13, 2023 •
edited

#381 #383

和 UI 确认过，UI 5.0 有两种弹窗面板。

  1. 没有 mask 的，需要通过弹窗上的关闭按钮关闭，能够做数据切换的
  2. 有 mask 的，和 antd 的 Drawer 类似

更改点

  1. 之前的 SlidePane 只拥有第一种弹窗，本次重构将第二种弹窗也添加上了。
  2. SlidePane 只是做了一个弹窗的功能，但是内部实现的 UI 都需要自己写。没写一个弹窗，header 的样式均需要重写，因此添加了 header 部分的样式，仅需要传入 title 即可
  3. 新版的 SlidePane 支持传入 tabs，也是 UI 5.0 常见的形式，SlidePane 将 Tabs 相关的样式也完成了。

具体例子，请查看SlidePane

mortalYoung
mortalYoung requested changes Sep 19, 2023
View reviewed changes
src/slidePane/index.tsx Outdated Show resolved Hide resolved
src/slidePane/index.tsx Outdated Show resolved Hide resolved
@LuckyFBB LuckyFBB changed the title WIP：Feat update slide pane Feat update slide pane Sep 20, 2023
mortalYoung
mortalYoung requested changes Sep 22, 2023
View reviewed changes
src/slidePane/index.tsx Outdated Show resolved Hide resolved
mortalYoung
mortalYoung approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mortalYoung mortalYoung merged commit 7630357 into DTStack:feat_5.x Sep 26, 2023
1 check passed
mumiao pushed a commit that referenced this pull request Nov 14, 2023
@LuckyFBB @mumiao
Feat update slide pane (#385)
36f7e2c 
* feat: update slidePane for mask

* feat(slidepane): add tabs for slidepane

* feat(slidepane): update motion for slidePane

* feat(slidepane): update ts error and style

* feat(slidepane): update doc and unit test

* fix(slidepane): update props name and edit showMask to mask

* fix(unittest): update unit test

* fix(slidepane): update ts type
mumiao added a commit that referenced this pull request Nov 14, 2023
@mumiao @LuckyFBB
@mortalYoung @dependabot @HaydenOrz @Cythia828 @JackWang032 @OnlyFlyer
React Component v5.x (#410)
8490b24 
* Feat update slide pane (#385)

* feat: update slidePane for mask

* feat(slidepane): add tabs for slidepane

* feat(slidepane): update motion for slidePane

* feat(slidepane): update ts error and style

* feat(slidepane): update doc and unit test

* fix(slidepane): update props name and edit showMask to mask

* fix(unittest): update unit test

* fix(slidepane): update ts type

* feat: add tinyTag (#396)

* feat: add tinyTag

* feat: support HTMLSpanElement's Attributes and color

* docs: update docs

* Feat image (#395)

* feat(intersectionobserver): add IntersectionObserver hook

* feat(intersectionobserver): update IntersectionObserver unit test

* feat(useintersectionobserver): use ref and add freezeOnceVisible

* feat(useintersectionobserver): update test unit

* feat(image): add image component

* feat(image): update review comment and mock window.Image

* feat(image): add image test

* feat(contentlayout): add contentLayout (#384)

* feat(contentlayout): add contentLayout

* feat(contentlayout): update contentLayout export table/header

* feat(contentlayout): update contentLayout info

* feat: update contentLayout md

* feat(contengtlayout): update contentLayout md

* feat(contentlayout): update some props

* feat: develop modal (#401)

* fix(useList): initialParams suppport function type (#393)

* build(deps-dev): bump browserify-sign from 4.2.1 to 4.2.2 (#399)

Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.2.
- [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md)
- [Commits](browserify/browserify-sign@v4.2.1...v4.2.2)

---
updated-dependencies:
- dependency-name: browserify-sign
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: import highlight core only (#402)

* feat: import highlight core only

* feat: improve Hljs types

* feat: add sideEffects field to improve treeShaking (#403)

* fix: upgrade SpreadSheet component for can be binded ref (#404)

Co-authored-by: zhaoge <>

* feat: add search component on sidebar (#405)

* feat: develop modal

* feat(Modal): improve banner check

* test: add test cases

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Hayden <hayden9653@gmail.com>
Co-authored-by: XCynthia <942884029@qq.com>

* Feat utils (#409)

* build(deps-dev): bump browserify-sign from 4.2.1 to 4.2.2 (#399)

Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.2.
- [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md)
- [Commits](browserify/browserify-sign@v4.2.1...v4.2.2)

---
updated-dependencies:
- dependency-name: browserify-sign
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: remove inner utils and add dt-utils dependence

* fix: fix pnpm-lock antd/icon patch version

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jialan <jialan@dtstack.com>

* feat: new component Catalogue in v5 (#389)

* feat(Catalogue): new component, catalogue initial

* chore(Catalogue): lint

* docs: update demo docs

* feat: clear searchStr when close search

* docs: update demo docs

* feat: add defaultStatus & onStatusChange props in Catalogue.DtTree

* chore: rename dtTree、dtTreeSelect to Tree、TreeSelect

* chore: update demos and docs

* chore: treeTit prop exchange to treeTitle

---------

Co-authored-by: dilu <dilu@dtstack.com>

* feat(filterrules): add FilterRules (#407)

* feat(filterrules): add FilterRules

* feat(filterrules): update some example

* feat(filterrules): add some example and props type and use weakMap to save height/lineheight

* feat(filterrules): update ts and add comment

* feat(filterrules): update FilterRules props and formitem name

* feat(filterrules): add comment and unit test

* feat(filterrrules): update contants file and style

* test(filterrules): update test unit

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: 霜序 <38368040+LuckyFBB@users.noreply.github.com>
Co-authored-by: 野迂迂 <yangwei1@outlook.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Hayden <hayden9653@gmail.com>
Co-authored-by: XCynthia <942884029@qq.com>
Co-authored-by: JackWang032 <64318393+JackWang032@users.noreply.github.com>
Co-authored-by: jialan <jialan@dtstack.com>
Co-authored-by: Frank <scofield90.email@gmail.com>
Co-authored-by: dilu <dilu@dtstack.com>
mumiao pushed a commit that referenced this pull request Nov 15, 2023
@LuckyFBB @mumiao
Feat update slide pane (#385)
39b52ea 
* feat: update slidePane for mask

* feat(slidepane): add tabs for slidepane

* feat(slidepane): update motion for slidePane

* feat(slidepane): update ts error and style

* feat(slidepane): update doc and unit test

* fix(slidepane): update props name and edit showMask to mask

* fix(unittest): update unit test

* fix(slidepane): update ts type
@mumiao mumiao changed the title Feat update slide pane feat: update slide pane Nov 15, 2023
mumiao pushed a commit that referenced this pull request Nov 15, 2023
@LuckyFBB @mumiao
Feat update slide pane (#385)
bc97bb8 
* feat: update slidePane for mask

* feat(slidepane): add tabs for slidepane

* feat(slidepane): update motion for slidePane

* feat(slidepane): update ts error and style

* feat(slidepane): update doc and unit test

* fix(slidepane): update props name and edit showMask to mask

* fix(unittest): update unit test

* fix(slidepane): update ts type
@LuckyFBB LuckyFBB mentioned this pull request Nov 15, 2023
Closed
8 tasks
mumiao pushed a commit that referenced this pull request Nov 15, 2023
@LuckyFBB @mumiao
feat: support additional features for slidePane (#385)
9fd9eaf 
* feat: update slidePane for mask

* feat(slidepane): add tabs for slidepane

* feat(slidepane): update motion for slidePane

* feat(slidepane): update ts error and style

* feat(slidepane): update doc and unit test

* fix(slidepane): update props name and edit showMask to mask

* fix(unittest): update unit test

* fix(slidepane): update ts type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortalYoung mortalYoung mortalYoung approved these changes

@liuxy0551 liuxy0551 Awaiting requested review from liuxy0551

@mumiao mumiao Awaiting requested review from mumiao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LuckyFBB @mortalYoung