Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(input): develop input.match #316

Merged
merged 4 commits into from
Apr 25, 2023
Merged

feat(input): develop input.match #316

merged 4 commits into from
Apr 25, 2023

Conversation

mortalYoung
Copy link
Collaborator

@mortalYoung mortalYoung commented Apr 20, 2023 •
edited
Loading

简介

  • 开发 input.match 组件（原 MultiSearchInput 组件）

遗留问题

@mortalYoung mortalYoung added the refactor This will improved code readability and reduced complexity label Apr 20, 2023
@mortalYoung mortalYoung added this to the Next Version(4.0.0） milestone Apr 20, 2023
@mortalYoung mortalYoung self-assigned this Apr 20, 2023
@mumiao
Copy link
Collaborator

mumiao commented Apr 21, 2023

BatchWorks里面的组件 @liuxy0551

@mumiao mumiao requested a review from shiqiWang0 April 21, 2023 09:58
@mortalYoung
Copy link
Collaborator Author

Preview: here

@mumiao
Copy link
Collaborator

mumiao commented Apr 25, 2023

@mortalYoung 除了UI部分和我提的DEMO部分，其他Review 没啥问题，changelog记得更新下

@mumiao
Copy link
Collaborator

mumiao commented Apr 25, 2023

有冲突

@mumiao
Copy link
Collaborator

mumiao commented Apr 25, 2023

有冲突，其他的+1

@mortalYoung mortalYoung changed the title WIP: feat(input): develop input.match feat(input): develop input.match Apr 25, 2023
@mumiao
Copy link
Collaborator

mumiao commented Apr 25, 2023

单测挂了

@liuxy0551
Copy link
Collaborator

image

@mumiao mumiao merged commit 683667c into DTStack:feat_v4 Apr 25, 2023
1 check passed
@mortalYoung mortalYoung deleted the feat/match branch June 13, 2023 02:42
@OnlyFlyer
Copy link
Collaborator

image

MultiSearchInput 组件有两处改动：

  1. 重命名为 Input.Match
  2. onChange 回调的参数由 string 改为了 e（文档上未标注）

https://dtstack.github.io/dt-react-component/guide/migration-v4

image@

@mumiao

@mumiao
Copy link
Collaborator

mumiao commented Aug 4, 2023

@OnlyFlyer 来个PR，😄

OnlyFlyer pushed a commit to OnlyFlyer/dt-react-component that referenced this pull request Aug 9, 2023
docs: DTStack#316, update MultiSearchInput comp migrationv4 doc
94f3dda
mumiao pushed a commit that referenced this pull request Aug 9, 2023
@OnlyFlyer
docs: #316, update MultiSearchInput comp migrationv4 doc (#370)
7828c22 
Co-authored-by: dilu <dilu@dtstack.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumiao mumiao mumiao approved these changes

@liuxy0551 liuxy0551 Awaiting requested review from liuxy0551

@shiqiWang0 shiqiWang0 Awaiting requested review from shiqiWang0

Assignees

@mortalYoung mortalYoung

Labels
refactor This will improved code readability and reduced complexity
Projects
None yet
Milestone
Next Version(4.0.0）
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mortalYoung @mumiao @liuxy0551 @OnlyFlyer