Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve highlighting of hive lanuguage #59

Merged
merged 4 commits into from
Nov 1, 2023
Merged

feat: improve highlighting of hive lanuguage #59

merged 4 commits into from
Nov 1, 2023

Conversation

HaydenOrz
Copy link
Collaborator

主要变更

优化 hivesql 的高亮功能 #55 #26

@HaydenOrz HaydenOrz added the improvement Improve existing feature label Oct 31, 2023
@HaydenOrz HaydenOrz requested a review from mumiao October 31, 2023 05:57
@HaydenOrz HaydenOrz self-assigned this Oct 31, 2023
@HaydenOrz HaydenOrz marked this pull request as draft October 31, 2023 13:39
@HaydenOrz
Copy link
Collaborator Author

TODO: Numberic 字面量匹配目前并不完整，比如支持 123L 、346Y、990.9S 等“
参考文档： https://cwiki.apache.org/confluence/display/Hive/Literals

@HaydenOrz
Copy link
Collaborator Author

TODO: Numberic 字面量匹配目前并不完整，比如支持 123L 、346Y、990.9S 等“ 参考文档： https://cwiki.apache.org/confluence/display/Hive/Literals

特殊的字面量格式，是否需要支持后续需要讨论，暂时先不支持

@HaydenOrz HaydenOrz marked this pull request as ready for review November 1, 2023 03:42
@mumiao mumiao merged commit 43c14c8 into DTStack:main Nov 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumiao mumiao mumiao approved these changes

Assignees

@HaydenOrz HaydenOrz

Labels
improvement Improve existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HaydenOrz @mumiao