Skip to content
This repository has been archived by the owner on May 4, 2024. It is now read-only.

Importing "Conditions (ML)" page #10

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Importing "Conditions (ML)" page #10

merged 1 commit into from
Sep 12, 2023

Conversation

a-thansen
Copy link
Contributor

test!

@a-thansen a-thansen self-assigned this Sep 8, 2023
@a-thansen a-thansen closed this Sep 8, 2023
@a-thansen a-thansen reopened this Sep 8, 2023
@Seb-sti1 Seb-sti1 marked this pull request as draft September 8, 2023 15:38
@Seb-sti1 Seb-sti1 added documentation Improvements or additions to documentation feature New feature or request frontend Frontend related labels Sep 8, 2023
@Seb-sti1 Seb-sti1 added this to the Version 0 milestone Sep 8, 2023
@Seb-sti1 Seb-sti1 linked an issue Sep 8, 2023 that may be closed by this pull request
Importing from given LiRa-Viz #7
Closed
4 tasks
@Seb-sti1 Seb-sti1 changed the title Create blanktest.tsx Importing "Conditions (ML)" page Sep 8, 2023
@Seb-sti1 Seb-sti1 mentioned this pull request Sep 8, 2023
Closed
4 tasks
@a-thansen
Copy link
Contributor Author

a-thansen commented Sep 11, 2023 •
edited
Loading

Errors w dependency conflicts for packages react-leaflet and react (TO BE FIXED)
Also "no interface 'JSX.IntrinsicElements' exists" throughout (not v sure how to fix this)

Seb-sti1
Seb-sti1 suggested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@Seb-sti1 Seb-sti1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍
For the small modifications that I suggested, we can talk about them tomorrow :-)

package.json Outdated Show resolved Hide resolved
frontend/src/Components/RoadConditions/BoundedWays.tsx Outdated Show resolved Hide resolved
frontend/src/Components/Map/WithBounds.tsx Outdated Show resolved Hide resolved
frontend/src/Components/Map/Hooks/useMapBounds.tsx Outdated Show resolved Hide resolved
frontend/package.json Outdated Show resolved Hide resolved
@a-thansen a-thansen marked this pull request as ready for review September 12, 2023 06:22
@a-thansen a-thansen force-pushed the conditions-ML branch 6 times, most recently from 4f15c39 to a7e41d6 Compare September 12, 2023 07:43
@a-thansen
Copy link
Contributor Author

Bug w test in CI, otherwise should be good to go

@a-thansen a-thansen added this pull request to the merge queue Sep 12, 2023
Merged via the queue into dev with commit 4e77a52 Sep 12, 2023
1 of 2 checks passed
@a-thansen a-thansen deleted the conditions-ML branch September 12, 2023 08:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marcosantiagomuro marcosantiagomuro marcosantiagomuro left review comments

@Seb-sti1 Seb-sti1 Seb-sti1 approved these changes

Assignees

@a-thansen a-thansen

Labels
documentation Improvements or additions to documentation feature New feature or request frontend Frontend related
Projects
None yet
Milestone
Release 0
Development

Successfully merging this pull request may close these issues.

Importing from given LiRa-Viz
3 participants
@a-thansen @Seb-sti1 @marcosantiagomuro