Skip to content
This repository has been archived by the owner on May 4, 2024. It is now read-only.

Create a function to import ways from OSM #100

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Create a function to import ways from OSM #100

merged 3 commits into from
Nov 9, 2023

Conversation

Seb-sti1
Copy link
Contributor

@Seb-sti1 Seb-sti1 commented Nov 3, 2023 •
edited

  • Add possibility to import a road, give an osm id of one way of the road
  • Small adjustment of the Road component

@Seb-sti1 Seb-sti1 linked an issue Nov 5, 2023 that may be closed by this pull request
Road & Survey: Import data of ways and display roads/survey #76
Closed
3 tasks
@Seb-sti1 Seb-sti1 force-pushed the import-ways branch 4 times, most recently from 86f5047 to b368896 Compare November 7, 2023 22:33
@Seb-sti1 Seb-sti1 self-assigned this Nov 7, 2023
@Seb-sti1 Seb-sti1 added this to the Release 2 milestone Nov 7, 2023
@Seb-sti1 Seb-sti1 added bug Something isn't working feature New feature or request frontend Frontend related backend Baclend related Main map Features related to the main map page Inspect map Features related to the inspect map page labels Nov 7, 2023
@Seb-sti1 Seb-sti1 marked this pull request as ready for review November 7, 2023 22:37
Seb-sti1
Seb-sti1 commented Nov 7, 2023
View reviewed changes
Copy link
Contributor Author

@Seb-sti1 Seb-sti1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems good to me, I know it may seem quite complex, but hopefully we have time tomorrow to review it together

@Seb-sti1 Seb-sti1 removed the bug Something isn't working label Nov 7, 2023
marcosantiagomuro
marcosantiagomuro approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@marcosantiagomuro marcosantiagomuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we can look at it tomorrow, I will be able to join after class (around 16 I hope) :(

@Seb-sti1
Add author in backend and cleanup
cb5e603
@Seb-sti1
Import ways of a road
274c04b 
- Get ways from OSM
- Insert ways in db

wip - front

wip - Construct road
@Seb-sti1
Show Roads
5e2de46 
- Road forming
- Update Road component
@Seb-sti1 Seb-sti1 merged commit 1a6fc72 into dev Nov 9, 2023
6 checks passed
@Seb-sti1 Seb-sti1 deleted the import-ways branch November 9, 2023 16:55
marcosantiagomuro
marcosantiagomuro reviewed Nov 9, 2023
View reviewed changes
Copy link
Contributor

@marcosantiagomuro marcosantiagomuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marcosantiagomuro marcosantiagomuro marcosantiagomuro approved these changes

Assignees

@Seb-sti1 Seb-sti1

Labels
backend Baclend related feature New feature or request frontend Frontend related Inspect map Features related to the inspect map page Main map Features related to the main map page
Projects
None yet
Milestone
Release 2
Development

Successfully merging this pull request may close these issues.

Road & Survey: Import data of ways and display roads/survey
2 participants
@Seb-sti1 @marcosantiagomuro