Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used module for file matching #8

Closed
wants to merge 3 commits into from
Closed

Used module for file matching #8

wants to merge 3 commits into from

Conversation

jarofghosts
Copy link
Collaborator

Hey! Let me know what you think about this change. The main thing is I am using glob to recurse and find readme files, also I am displaying the module name as a link to the readme.

@DTrejo
Copy link
Owner

DTrejo commented Mar 11, 2014

Seems good!

Are you cool with making it 2-space indent?

Please feel free to merge it once you've made the update (and publish to npm or whatever as well — probably best to increment the major version since I don't know if the file-finding works the same, up to you)

@jarofghosts
Copy link
Collaborator Author

Definitely! I prefer two space but it looked like the rest of the file was
four so I just tried to match it. Will fix it up when I get home and then
start looking at brucedown.
On Mar 11, 2014 2:03 PM, "David Trejo" notifications@github.com wrote:

Seems good!

Are you cool with making it 2-space indent?

Please feel free to merge it once you've made the update (and publish to
npm or whatever as well -- probably best to increment the major version
since I don't know if the file-finding works the same, up to you)

Reply to this email directly or view it on GitHubhttps://github.com//pull/8#issuecomment-37349589
.

@DTrejo
Copy link
Owner

DTrejo commented Mar 11, 2014

Also I don't really like merge commits, so if you feel like rebasing on
master then that'd also be cool. I can teach you to rebase over ghangout at
some point if you'd like

On Tue, Mar 11, 2014 at 2:05 PM, jesse keane notifications@github.comwrote:

Definitely! I prefer two space but it looked like the rest of the file was
four so I just tried to match it. Will fix it up when I get home and then
start looking at brucedown.
On Mar 11, 2014 2:03 PM, "David Trejo" notifications@github.com wrote:

Seems good!

Are you cool with making it 2-space indent?

Please feel free to merge it once you've made the update (and publish to
npm or whatever as well -- probably best to increment the major version
since I don't know if the file-finding works the same, up to you)

Reply to this email directly or view it on GitHub<
https://github.com/DTrejo/readmetree/pull/8#issuecomment-37349589>

.

Reply to this email directly or view it on GitHubhttps://github.com//pull/8#issuecomment-37349881
.

See my projects at dtrejo.com

@jarofghosts
Copy link
Collaborator Author

Oh I can do that. I just usually don't for personal stuff. Will do!
On Mar 11, 2014 2:08 PM, "David Trejo" notifications@github.com wrote:

Also I don't really like merge commits, so if you feel like rebasing on
master then that'd also be cool. I can teach you to rebase over ghangout at
some point if you'd like

On Tue, Mar 11, 2014 at 2:05 PM, jesse keane <notifications@github.com

wrote:

Definitely! I prefer two space but it looked like the rest of the file
was
four so I just tried to match it. Will fix it up when I get home and then
start looking at brucedown.
On Mar 11, 2014 2:03 PM, "David Trejo" notifications@github.com wrote:

Seems good!

Are you cool with making it 2-space indent?

Please feel free to merge it once you've made the update (and publish
to
npm or whatever as well -- probably best to increment the major version
since I don't know if the file-finding works the same, up to you)

Reply to this email directly or view it on GitHub<
https://github.com/DTrejo/readmetree/pull/8#issuecomment-37349589>

.

Reply to this email directly or view it on GitHub<
https://github.com/DTrejo/readmetree/pull/8#issuecomment-37349881>
.

See my projects at dtrejo.com

Reply to this email directly or view it on GitHubhttps://github.com//pull/8#issuecomment-37350255
.

@jarofghosts jarofghosts deleted the use-glob branch March 11, 2014 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants