-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch/fddaq v4.4.x #364
Merged
Merged
Patch/fddaq v4.4.x #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce to support our desire to not complain too loudly when late-arriving TPs can't be added to existing TimeSlices in the TPStreamWriter.
…mWriter and to better track such a condition with additional metrics.
… the TimeSlice class where it is used in the TPStreamWriter code.
…s an Attribute inside the HDF5 file. This required a bit of reworking of the file_index logic.
… file size as the primary criteria (and using the one-event-per-file as the secondary constraint).
…ct one tp_dlh per plane and to wait a little bit of time at the start of a run before enabling triggers.
Fixed the file_index Attribute inside long-readout-window HDF5 files when one-event-per-file is enabled
…discussion at 03-July Core SW meeting
…tpsw_ignore_late_tps
Changes to avoid warning messages when tardy TPs arrive at the TPStreamWriter
updated integtests in dfmodules to work in fddaq-v4.4.x
Updated version to v2.14.3
jcfreeman2
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.