-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thread pinning #243
Thread pinning #243
Conversation
…t a digestable amount of information
… pin thread and execute it
This needs to be used with DUNE-DAQ/fddaqconf#20 (but not necessarily, as this is backwards compatible) |
Just tested at EHN1. Works / is backwards compatible with existing configs for workflow at NP04. Reduced messages are very nice, though could additionally suppress the details on the pin command. Fixes the spurious error on pin_threads for WIBs/hermes/etc. I would be happy to see this in fddaq-v4.3.0, even without DUNE-DAQ/fddaqconf#20. |
@@ -65,14 +65,13 @@ def ls(obj, legend): | |||
|
|||
|
|||
@click.command() | |||
@click.option('--pin-thread-file', type=click.Path(exists=True, resolve_path=True), default=None) | |||
@click.argument('pin-thread-file', type=click.Path(exists=True, resolve_path=True)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this change is not backwards compatible, right? It means that a pin_threads
command now must have an argument of the thread pinning file, and won't default to what has been set in the environment. This may be ok, but would break instructions/workflows that have been given to others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, but if one has more than one thread pinning file, I'm not sure how I should choose it without specifying an argument here.
@plasorak is it possible to split out the changes on the verbosity of print messages and the errors on WIB/hermes/etc. blocks versus the other updates that are tied to the configuration? If so, that may be enough to get in now, and allow for further discussion if needed on the other elements, assuming that is needed. |
I can certainly cherry-pick the commits which reduce the printout. For the WIB/Hermes errors, if you are referring to DUNE-DAQ/ehn1-operations-issues#19, yes that can be done too. |
done here: #244 |
…plasorak/thread-pinning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested at EHN1 and it seems to be working. Thanks!
Better thread pinning:
boot.json
.--loglevel debug
.