Manually place enemy zones #26
Conversation
First commits. I hope I'm doing this right!
I accidentally deleted _zones_array from locatorzonesV2 so I fixed it.
|
@bolbies You're doing just fine. What issue number where you trying to resolve with this or was there another issue? If it was another issue I can create an issue and we can go from there. From this side it looks like you created the PR just fine 👍 |
| colorBackground[] = {1, 0, 0,0.5}; | ||
| tooltip = "Manually generate the zones, then start the campaign"; //--- ToDo: Localize; | ||
| action = "_nul = [] execvm ""dialog\startup\startup_start2.sqf"""; | ||
| }; |
There was a problem hiding this comment.
@bolbies I know this is really nit-picky but can we please change the tab characters here to spaces? This appears to be the only block in this file that came across with tabs and not spaces. :-)
|
👀 Looking at this now. |
| commandpointsblu1 = 1000 | ||
| }; | ||
|
|
||
| case index_amount_cp_600: |
There was a problem hiding this comment.
There's a tab here, need spaces :-)
|
@bolbies Done with my first pass review. I have to head out right now... dang wife... @naitp @phr0gz Feel free to review as well. I only spent about 10 minutes on the first pass. I'll review again later when I get back home. Verdict - 🙅 |
|
I think I fixed the tabs. I'll make sure of that next time I post something. And the issue was from my own commit, not any of yours. |
|
@bolbies I checked out your |
|
I used the find/replace word tool to quickly turn the tabs into spaces and one of the variables at the bottom of startup_start2 got messed up. Sorry. Try it now. |
|
@bolbies Ha. Not a problem. Have you tried an IDE like IntelliJ or SQF Editor? Both have an option to convert whitespace to spaces. It'll safely change tabs to spaces. I use both interchangeably. |
| blufor_ap = 170; | ||
| }; | ||
|
|
||
| case index_ blufor_ap_200: |
There was a problem hiding this comment.
I think these are messed up :-) case index_ blufor_ap_...
|
Guess who's never using the replace tool ever again? Fixes are up. Hopefully it works now! |
|
Haha, it happens to all of us. I've been on the phone most of the evening and probably wont get to this until Wednesday. Thanks for making the edits! I strongly suggest using something like Squint, SQF Editor or IntelliJ with the SQF Plugin. All of the have an option to automatically convert tabs ( |
|
Yeah I downloaded Squint so I'll see how that works out later when I start something else. I'll see if I can knock out a few of the posted issues next. This is fun :) |
|
@bolbies All looked good to me from a code standpoint. Thanks for the addition. One area for improvement I'd like to see is that sometimes when I click nothing registers so I don't know if the script is analyzing to make sure the location I clicked is valid or if it's an invalid location. I'll create a new issue for this and we can address it in another PR. Also, I'm going to make some edits to get your PR into the format I'm planning to use going forward. This isn't a code edit; It's strictly just on this PR. |
👍 Merging #26 since the edits look good.
|
@bolbies You should join the @DUWS-R-Team/developers team. We would love to have you! |
Issue
Fixes #33
Summary
First commit. I hope I'm doing this right!