[Feature] Create User#getAsTag (#849)

discord-jda · Jan 2, 2019 · 2f53afb · 2f53afb
1 parent 15ac863
commit 2f53afb
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/src/main/java/net/dv8tion/jda/core/entities/User.java b/src/main/java/net/dv8tion/jda/core/entities/User.java
@@ -109,6 +109,14 @@ public interface User extends ISnowflake, IMentionable, IFakeable
      */
     String getEffectiveAvatarUrl();
 
+    /**
+     * The "tag" for this user
+     * <p>This is the equivalent of calling {@link java.lang.String#format(String, Object...) String.format}("%#s", {@link net.dv8tion.jda.core.entities.User User})
+     *
+     * @return Never-null String containing the tag for this user, for example DV8FromTheWorld#6297
+     */
+    String getAsTag();
+
     /**
      * Whether or not the currently logged in user and this user have a currently open
      * {@link net.dv8tion.jda.core.entities.PrivateChannel PrivateChannel} or not.

diff --git a/src/main/java/net/dv8tion/jda/core/entities/impl/UserImpl.java b/src/main/java/net/dv8tion/jda/core/entities/impl/UserImpl.java
@@ -92,6 +92,11 @@ public String getEffectiveAvatarUrl()
         return getAvatarUrl() == null ? getDefaultAvatarUrl() : getAvatarUrl();
     }
 
+    @Override
+    public String getAsTag()
+    {
+        return getName() + '#' + getDiscriminator();
+    }
 
     @Override
     public boolean hasPrivateChannel()
@@ -243,9 +248,9 @@ public void formatTo(Formatter formatter, int flags, int width, int precision)
         if (!alt)
             out = getAsMention();
         else if (upper)
-            out = String.format(formatter.locale(), "%S#%s", getName(), getDiscriminator());
+            out = getAsTag().toUpperCase();
         else
-            out = String.format(formatter.locale(), "%s#%s", getName(), getDiscriminator());
+            out = getAsTag();
 
         MiscUtil.appendTo(formatter, width, precision, leftJustified, out);
     }