Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question ChannelManager (VoiceChannel) #231

Closed
AntoninHuaut opened this issue Jan 10, 2017 · 2 comments
Closed

Question ChannelManager (VoiceChannel) #231

AntoninHuaut opened this issue Jan 10, 2017 · 2 comments
Assignees
@Almighty-Alpaca
Labels
bug

Comments

@AntoninHuaut
Copy link

AntoninHuaut commented Jan 10, 2017 •
edited
Loading

Hello,
How set UserLimit unlimited from a ChannelManager of a VoiceChannel ?
0 not working
Thank

totermw_2017-01-10_14-38-17
@AntoninHuaut AntoninHuaut changed the title Question ChannelManager Questions ChannelManager Jan 10, 2017
@AntoninHuaut AntoninHuaut changed the title Questions ChannelManager Questions ChannelManager and userTag Jan 10, 2017
@AntoninHuaut AntoninHuaut changed the title Questions ChannelManager and userTag Questions ChannelManager Jan 10, 2017
@AntoninHuaut AntoninHuaut changed the title Questions ChannelManager Question ChannelManager (VoiceChannel) Jan 10, 2017
@Dragorn421
Copy link

Dragorn421 commented Jan 10, 2017 •
edited
Loading

@MinnDevelopment the problem is here : https://github.com/DV8FromTheWorld/JDA/blob/620e380c424af6d0fc9f992a2ef0c4e37853ba03/src/main/java/net/dv8tion/jda/core/managers/ChannelManagerUpdatable.java#L203
The condition should be if (value < 0 || value > 99)
According to the discord documentation ( https://discordapp.com/developers/docs/resources/channel#modify-channel ) 0 is allowed and means no user limit.
EDIT: the exception message should be edited too

@Almighty-Alpaca Almighty-Alpaca self-assigned this Jan 10, 2017
@Almighty-Alpaca
Copy link
Collaborator

Fixed as of bea3fb0. The fix is in build 3.0.BETA2_120.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Almighty-Alpaca Almighty-Alpaca

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@AntoninHuaut @Dragorn421 @Almighty-Alpaca @MinnDevelopment