Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promise all #447

Merged
merged 6 commits into from
Oct 7, 2020
Merged

Promise all #447

merged 6 commits into from
Oct 7, 2020

Commits on Oct 6, 2020

  1. Git.ts update flat traverse and its test 

    check for false in promise reject for test
Promise.all resolves all promises concurrently
    @king-11
    king-11 committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    e745c47 View commit details
    Browse the repository at this point in the history

  2. resolve promises concurrent scanner and languageContext 

    resolve promise concurrently and then spread in languageContext.ts
scanner.ts return promise resolved by Promise.all
    @king-11
    king-11 committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    57299cf View commit details
    Browse the repository at this point in the history

  3. promise all and optional chaining update FileInspector.ts 

    options object maybe undefined hence use optional chaining
Promise all to run functions concurrently
    @king-11
    king-11 committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    0473d41 View commit details
    Browse the repository at this point in the history

  4. FileSystemService.ts update flat traverse and its test 

    check for false in promise reject for test
Promise.all resolves all promises concurrently
    @king-11
    king-11 committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    5765ad5 View commit details
    Browse the repository at this point in the history

  5. remove unnecessary import resolve error 

    change to Promise.allSettled coz each https request has to be completed
loop to check if rejection then return promise reject false
lodash unneeded import by auto import removed
    @king-11
    king-11 committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    1fdbdd4 View commit details
    Browse the repository at this point in the history

  6. fail function use and removing unnecessary variable 

    fail function to fail test with proper error
make code more concise
    @king-11
    king-11 committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    febdf71 View commit details
    Browse the repository at this point in the history