Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action Builder - Show to address in call details #9

Closed
rossneilson opened this issue May 30, 2022 · 1 comment · Fixed by #147
Closed

Action Builder - Show to address in call details #9

rossneilson opened this issue May 30, 2022 · 1 comment · Fixed by #147
Assignees
Labels

Comments

@rossneilson
Copy link
Contributor

It would be useful to show the to value of each of these calls also (the address). This should be outside of the function call data at the top level of the detailed/technical action view
Screenshot 2022-04-29 at 10 19 53

In addition we should also show value (native token transfer) for visibility only if it is > 0

@rossneilson rossneilson added the enhancement New feature or request label May 30, 2022
@rossneilson rossneilson changed the title Show to address in call details Action Builder - Show to address in call details May 30, 2022
@rossneilson rossneilson added this to the Davi v1.0.0 - 1 milestone Jun 1, 2022
@pimato
Copy link

pimato commented Jul 5, 2022

Hey guys,

I´ve been working on some improvements in terms of how we access and show advanced details for a specific action. I strongly recommend to play with my playground here.
Default

Changes:

  • Remove the default/function call horizontal picker navigation.
  • Replace the Function call view with a simple button which shows the code on click: FunctionCall
  • Figma design specification

If the defined action includes a native token transfer, we need to have a strong indicator as it might be an attack/dangerous action.

Default

Figma design specification
Playground

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants