Fix: disconnect wallet #250
Conversation
| const { chains } = useNetwork(); | ||
| const defaultChain = useMemo(() => { | ||
| const { chains, chain } = useNetwork(); | ||
| const validChain = useMemo(() => { | ||
| if (chains?.length === 0) return null; |
There was a problem hiding this comment.
I think you can remove this line, right?
There was a problem hiding this comment.
That's a very good question.
I tinkered with it to get an answer, and it seems that its removal won't affect the connection.
Maybe @mprasanjith can chime in?
Co-authored-by: Milton Tulli <milton.tulli@gmail.com>
|
Hey @dcrescimbeni, I am unable to build up local env this is what I get, do you have any ideas?
|
Yes! Should be fixed now |
|
✔️ Preview deployment is ready! 🔨 Explore the source changes: 54237c1 😎 Browse the preview: https://bafybeigc3u5srkctxgl5s2csd6g3afjdrrmy72h6qdjkhw5c3vmqdf5llu.ipfs.cf-ipfs.com |
|
✔️ Storybook deployment is ready! 😎 Browse Storybook: https://bafybeiejxwgz6hccom6dkdib6hd2pd7eapcgx5owsuga6wwjo4o4g5s4ly.ipfs.cf-ipfs.com |
|
@dcrescimbeni ty, I've check this PR, I'm able to disconnect my wallet now! After that I get switched to ETH network, is that expected behavior should we go with this? |
Interesting. Is a side effect of the I'll see if there's a way to mitigate it. For now I'll set this to draft |
|
@Filipv95 should be fixed now! |
|
✔️ Preview deployment is ready! 🔨 Explore the source changes: 2cc1d96 😎 Browse the preview: https://bafybeiduurtpjn2bnvshwupaxczt4yzto3mnj5kba5diwvow5goyugs74i.ipfs.cf-ipfs.com |
|
✔️ Storybook deployment is ready! 😎 Browse Storybook: https://bafybeigmtstkwkyfqwokdyuhkpfx5ulldvyz6pje2zi4fmaqrfm2ucswsu.ipfs.cf-ipfs.com |
|
@dcrescimbeni awesome, it works now! |
|
✔️ Preview deployment is ready! 🔨 Explore the source changes: 4ef5627 😎 Browse the preview: https://bafybeiebcfilasfmhga5ljunnngloivsp3irotokirnoxpbhlsyrs5mvf4.ipfs.cf-ipfs.com |
|
✔️ Storybook deployment is ready! 😎 Browse Storybook: https://bafybeiebfwvklibhabmfgfus7sfhipk4wb3sljzubol2e4nbh7gxu76cjm.ipfs.cf-ipfs.com |
Description
Fixed error while disconnecting wallet.
Added some translations.
Closes #243
Type of change
How Has This Been Tested?
Manual testing.
Checklist: