Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Crash due to ethers receiving null value. #326

Conversation

mprasanjith
Copy link
Member

Description

Fixes the app crashing with a white screen due to Ethers getting a null value.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested locally.

Checklist:

  • My code follows the existing style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any UI changes have been tested and made responsive for mobile views

@github-actions
Copy link

✔️ Preview deployment is ready!

🔨 Explore the source changes: b138787

😎 Browse the preview: https://bafybeihgs63nayqmqahimxvwgtqkkehaw33qn3v6b3r7ua3bzkwpnja7ni.ipfs.cf-ipfs.com

@github-actions
Copy link

✔️ Storybook deployment is ready!

😎 Browse Storybook: https://bafybeihkbcv5o5ramiy4jbfnhrc2kq2ls4hmirt76uhx3qdvmymatggemy.ipfs.cf-ipfs.com

@mprasanjith mprasanjith merged commit 18a1cac into DXgovernance:develop Sep 19, 2022
@mprasanjith mprasanjith deleted the bugfix/crash-in-isproposalcreationallowed-hook branch September 19, 2022 18:50
@Filipv95
Copy link
Contributor

@rossneilson this PR fixes #328 if I'm not wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants