Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix block explorer links #411

Merged
merged 10 commits into from Nov 21, 2022
Merged

Fix block explorer links #411

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cd59390
add component for block explorer links
rulfo71 Nov 7, 2022
e72c6df
extending BlockExplorerLink component functionalities
rulfo71 Nov 8, 2022
a893b93
remove unstyledLink, add usage for BlockExplorerLink
rulfo71 Nov 11, 2022
5498a6d
update snapshots
rulfo71 Nov 11, 2022
c57f07b
remove property unstyled from BlockExplorerLink component
rulfo71 Nov 11, 2022
4655233
add snapshots
rulfo71 Nov 11, 2022
c757bab
add tests
rulfo71 Nov 14, 2022
849a320
remove comments
rulfo71 Nov 18, 2022
ed4638f
remove unused line
rulfo71 Nov 18, 2022
b2fe2d7
change block explorer of gnosis to gnosisscan
rulfo71 Nov 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/ActionsBuilder/CallDetails/CallDetails.test.tsx
View file
Open in desktop
Expand Up @@ -25,6 +25,7 @@ jest.mock('utils', () => ({
},
}),
preventEmptyString: () => mockBigNumber,
shortenAddress: () => {},
}));

jest.mock('wagmi', () => ({
Expand Down
11 changes: 2 additions & 9 deletions src/components/ActionsBuilder/CallDetails/CallDetails.tsx
View file
Open in desktop
Expand Up @@ -4,8 +4,6 @@ import { BigNumber } from 'ethers';
import { Button } from 'components/primitives/Button';
import { Box } from 'components/primitives/Layout/Box';
import { Flex } from 'components/primitives/Layout/Flex';
import { UnstyledLink } from 'components/primitives/Links';
import { FiExternalLink } from 'react-icons/fi';
import { useTheme } from 'styled-components';
import { Divider } from 'components/Divider';
import { getSummaryView } from '../SupportedActions';
Expand All @@ -23,6 +21,7 @@ import { useTranslation } from 'react-i18next';
import { FunctionParamWithValue } from 'components/ActionsBuilder/SupportedActions/GenericCall/GenericCallInfoLine';
import { SupportedAction } from 'components/ActionsBuilder/types';
import { renderGenericCallParamValue } from 'components/ActionsBuilder/SupportedActions/GenericCall/GenericCallParamsMatcher';
import { BlockExplorerLink } from 'components/primitives/Links/BlockExplorerLink';

type Param = Partial<FunctionParamWithValue>;

Expand All @@ -39,13 +38,7 @@ function renderDefaultParamValue(param: Param) {
if (!param) return null;

if (param.type === 'address') {
return (
<UnstyledLink to="#">
<ParamDetail>
{param.value} <FiExternalLink size={16} />
</ParamDetail>
</UnstyledLink>
);
return <BlockExplorerLink address={param.value} unstyled />;
}

if (param.type.startsWith('uint') || param.type.startsWith('int')) {
Expand Down