Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixing voting power on vote transaction for snapshot guilds #414

Merged

Conversation

rossneilson
Copy link
Contributor

@rossneilson rossneilson commented Nov 8, 2022

Description

Fixes

  • Issue of sending non snapshot voting power to contract despite UI showing correct amount (test by creating proposal->lock tokens->vote in proposal)
  • Fixes position of quorum flag
  • Adds ENS subdomain usage for contracts and tokens
  • Uses new token list
  • Makes token list scrollable

Closes #412

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • My code follows the existing style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any UI changes have been tested and made responsive for mobile views

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

✔️ Storybook deployment is ready!

😎 Browse Storybook: https://bafybeihvsgeahtvnnuxmtyttkcu7dbuijf4o4qjfqwzut5yduhvgmm4qpy.ipfs.cf-ipfs.com

@rossneilson rossneilson requested a review from a team November 9, 2022 14:31
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

✔️ Storybook deployment is ready!

😎 Browse Storybook: https://bafybeid6dbgvjnoszp2u4uookowdsduew55s7oyod6zkirx33cisoj4yi4.ipfs.cf-ipfs.com

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

✔️ Storybook deployment is ready!

😎 Browse Storybook: https://bafybeicad7t5r2q3gdo56j7g6hcxa6x6jumjrxuwhbyqbvpgc6la7rrqoq.ipfs.cf-ipfs.com

@rossneilson rossneilson merged commit 8527018 into DXgovernance:develop Nov 9, 2022
@rulfo71 rulfo71 mentioned this pull request Nov 21, 2022
@Filipv95
Copy link
Contributor

Hey @rossneilson jsut to double check, I've created Proposal with 25% VP, locked more tokens and got 33% VP, when I voted in Proposal my vote impact was 25% VP.
If I understood this is correct behavior because snapshots is done at the moment proposal is created, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ENS instead of IPFS hashes
3 participants