fix(contracts): minor changes to fix compilation warnings #134
Conversation
|
The only compilation warnings lefts are the ones form the VotingMacineCallbacks from daostack contracts that we dont want to change them yet. |
| @@ -412,7 +412,7 @@ contract WalletScheme { | |||
| function mintReputation( | |||
| uint256 _amount, | |||
| address _beneficiary, | |||
| bytes32 _proposalId | |||
| bytes32 | |||
There was a problem hiding this comment.
Hey! This is a question for me to understand better about unnamed parameters.
Since in this case you are not overriding other function, why is it that you are including it?
There was a problem hiding this comment.
because in the VotingmachineCallbacks that we are extending it always passes the proposalId, but im not using it, in fact I think no scheme is using it but it was defined like that when it was written years ago.
So I just remove the parameter name and I leave it empty, this way the function signature will be the same as it uses three params, but im only using two.
Bad practice, but wel..thats what we get from supporting this legacy contracts
No description provided.