Feature/deploy guilds script #137
Conversation
|
|
||
| guildActions: [ |
There was a problem hiding this comment.
Running guildActions before or after the "dao" actions wont allow run actions in between them, and thats one of the things we want to tests in the DXDGuild.
I think we should be able to run dao and guild actions at the same time, this means having a single actions array, not actions a& guildActions
There was a problem hiding this comment.
Good point, just means replicating some code but can do that
scripts/utils/deploy-tokens.js
Outdated
|
|
||
| let tokens = {}; | ||
| let addresses = {}; | ||
| // await Promise.all( |
There was a problem hiding this comment.
commended code and console log here
There was a problem hiding this comment.
Was still debugging stuff but will remove it and comment once its all working
|
|
||
| let newToken; | ||
| switch (tokenToDeploy.type) { | ||
| case "ERC20": |
There was a problem hiding this comment.
lets use the ERC20 case on default.
scripts/utils/do-actions.js
Outdated
| tokens, | ||
| addresses, | ||
| avatar, | ||
| guilds, |
There was a problem hiding this comment.
instead of sendinga guidls object with the contract maybe you can take the address of the guild in the addresses obj and instantiate an ERC20Guild contract on the address, then execute the guild actions
Use timetsamp and increaseTime for script actions, remove duplicated execution of do-actions, remove unnecessary variables in functions like ipfs, remove console logs, instantiate smart contracts for actions based on their name from the addresses object, and maybe something else im forgetting but that should me most of it.
Looks to be working now with both of the below commands
yarn hardhat --network localhost deploy-dxvote-developyarn hardhat --network localhost deploy-guilds-develop --registry 0x0