New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Setup storybook and add ProposalCard stories. #868
feat: Setup storybook and add ProposalCard stories. #868
Conversation
✔️ Preview deployment is ready! 🔨 Explore the source changes: 64a0bd3 😎 Browse the preview: https://bafybeicwccrsls2byibfqx7vmj7hr6xtwicfzb52iffybsexdsv7eduhhy.ipfs.dweb.link |
This is great, just need the fixtures stuff we talked about in standup. Also moving stories and fixtures files up into the individual component folders |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Another cool thing we can add is preview deployment of storybook generated page on each pr. Not necessary in this pr.
✔️ Preview deployment is ready! 🔨 Explore the source changes: 68de1c6 😎 Browse the preview: https://bafybeif7etrsvedbmbgoioeu2pv4rerynau4zs7u4rdtfhrcnz6pqv7s5q.ipfs.dweb.link |
✔️ Preview deployment is ready! 🔨 Explore the source changes: e6c1be5 😎 Browse the preview: https://bafybeif7etrsvedbmbgoioeu2pv4rerynau4zs7u4rdtfhrcnz6pqv7s5q.ipfs.dweb.link |
✔️ Preview deployment is ready! 🔨 Explore the source changes: dae244e 😎 Browse the preview: https://bafybeif7etrsvedbmbgoioeu2pv4rerynau4zs7u4rdtfhrcnz6pqv7s5q.ipfs.dweb.link |
✔️ Preview deployment is ready! 🔨 Explore the source changes: 3c59137 😎 Browse the preview: https://bafybeif7etrsvedbmbgoioeu2pv4rerynau4zs7u4rdtfhrcnz6pqv7s5q.ipfs.dweb.link |
✔️ Preview deployment is ready! 🔨 Explore the source changes: 491a10d 😎 Browse the preview: https://bafybeif7etrsvedbmbgoioeu2pv4rerynau4zs7u4rdtfhrcnz6pqv7s5q.ipfs.dweb.link |
I've moved the stories and fixtures as we discussed. Also added the Github pipeline for Storybook. It won't deploy until the storybook-deploy.yml file is in the main branch though. For now, you can see it working on my fork here. |
✔️ Preview deployment is ready! 🔨 Explore the source changes: 070006e 😎 Browse the preview: https://bafybeifl3d7af5m3t5kevosm74qcz7ts7bcszuemz7aurqosv5q6av6yc4.ipfs.dweb.link |
@@ -6,5 +6,5 @@ export interface ProposalCardProps { | |||
votes?: number[]; | |||
ensAvatar?: ENSAvatar; | |||
href?: string; | |||
statusProps: ProposalStatusProps; | |||
statusProps?: ProposalStatusProps; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remember to make render this as a child and not prop drill
Description
Adds storybook and implements the configurations needed to get Guilds components working.
Also adds an example story for the
ProposalCard
component.Type of change
How Has This Been Tested?
Tested locally.
Checklist: