Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Setup storybook and add ProposalCard stories. #868

Merged

Conversation

mprasanjith
Copy link
Member

Description

Adds storybook and implements the configurations needed to get Guilds components working.

Also adds an example story for the ProposalCard component.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested locally.

Checklist:

  • My code follows the existing style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any UI changes have been tested and made responsive for mobile views

@mprasanjith mprasanjith added Enhancement New feature or request UI/UX Improvements Any improvement to user experience or FE labels May 11, 2022
@mprasanjith mprasanjith requested review from rossneilson and a team May 11, 2022 14:08
@mprasanjith mprasanjith self-assigned this May 11, 2022
@github-actions
Copy link

✔️ Preview deployment is ready!

🔨 Explore the source changes: 64a0bd3

😎 Browse the preview: https://bafybeicwccrsls2byibfqx7vmj7hr6xtwicfzb52iffybsexdsv7eduhhy.ipfs.dweb.link

@rossneilson
Copy link
Collaborator

This is great, just need the fixtures stuff we talked about in standup. Also moving stories and fixtures files up into the individual component folders

MiltonTulli
MiltonTulli previously approved these changes May 12, 2022
Copy link
Member

@MiltonTulli MiltonTulli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Another cool thing we can add is preview deployment of storybook generated page on each pr. Not necessary in this pr.

@github-actions
Copy link

✔️ Preview deployment is ready!

🔨 Explore the source changes: 68de1c6

😎 Browse the preview: https://bafybeif7etrsvedbmbgoioeu2pv4rerynau4zs7u4rdtfhrcnz6pqv7s5q.ipfs.dweb.link

@github-actions
Copy link

✔️ Preview deployment is ready!

🔨 Explore the source changes: e6c1be5

😎 Browse the preview: https://bafybeif7etrsvedbmbgoioeu2pv4rerynau4zs7u4rdtfhrcnz6pqv7s5q.ipfs.dweb.link

@github-actions
Copy link

✔️ Preview deployment is ready!

🔨 Explore the source changes: dae244e

😎 Browse the preview: https://bafybeif7etrsvedbmbgoioeu2pv4rerynau4zs7u4rdtfhrcnz6pqv7s5q.ipfs.dweb.link

@github-actions
Copy link

✔️ Preview deployment is ready!

🔨 Explore the source changes: 3c59137

😎 Browse the preview: https://bafybeif7etrsvedbmbgoioeu2pv4rerynau4zs7u4rdtfhrcnz6pqv7s5q.ipfs.dweb.link

@github-actions
Copy link

✔️ Preview deployment is ready!

🔨 Explore the source changes: 491a10d

😎 Browse the preview: https://bafybeif7etrsvedbmbgoioeu2pv4rerynau4zs7u4rdtfhrcnz6pqv7s5q.ipfs.dweb.link

@mprasanjith
Copy link
Member Author

I've moved the stories and fixtures as we discussed. Also added the Github pipeline for Storybook. It won't deploy until the storybook-deploy.yml file is in the main branch though. For now, you can see it working on my fork here.

@github-actions
Copy link

✔️ Preview deployment is ready!

🔨 Explore the source changes: 070006e

😎 Browse the preview: https://bafybeifl3d7af5m3t5kevosm74qcz7ts7bcszuemz7aurqosv5q6av6yc4.ipfs.dweb.link

@@ -6,5 +6,5 @@ export interface ProposalCardProps {
votes?: number[];
ensAvatar?: ENSAvatar;
href?: string;
statusProps: ProposalStatusProps;
statusProps?: ProposalStatusProps;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remember to make render this as a child and not prop drill

@mprasanjith mprasanjith merged commit 6791347 into DXgovernance:v1.1-beta May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request UI/UX Improvements Any improvement to user experience or FE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants