New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boquets entry with Youtube URL- detection and formating. #170
Comments
Hi, |
Work as intended, then in current state I don’t see any practical application for that function. I tested also Windows version it is even worse. I made a video, that may better elaborate what I’m consider as error. Video_2023_03_23-2.mp4It reminds me those old fashion way web advertisement when you had to chase X to close the window. When dialog box requires user to additional reaction and after that reaction you see the same dialog box in different position, you can start suspecting a false loop. Fortunately it ends at second time. |
But I see... :) I don't need additional plugins. I don't have to worry about inserting various prefixes and etc. to briefly look at any video or playlist. Аnd there are enough such users.
Yes, this looks like a bug. I'll take a look. |
Should be fixed. Regarding this:
and this:
You should read about the "correct" URL and about escaping for it. In your case (IMHO), this is a "crutch" for a particular plugin. |
Thank you for your work and being open for suggestions. You are working very fast. Double popup is gone, that is very good news. I used word correct in terms what enigma2 will recognize as correct entry and play it. So that's conditional based on environment. Back to the point, drop-down list is a great solution that I have not seen before, well though, easy to change and dose not interfere. That makes sense to me. I don’t have to wounder if prefix flex is correct, that simplifies usage of copy/paste function as well. However I didn’t manage to get playback, but that also stopped working me on older version, so may be something else. This entry is not recognized as prefix. http://127.0.0.1:8088/. Internal url or prefix that may be debatable. This is actually for older solution called Streamlinksrv (not wrapper), default ip and port of course, that can be a changed. On older images more important than on newer ones. Maybe off topic. This type of drop-down list is a potential solution to other problems. Custom prefix option, or prefix as a variable defined in a separate option. Or something more complicated like a custom prefix list. Perhaps this could also be a way to handle other solutions that use a prefix like Stream Relay, where the default port is usually used (17999), but can be easily changed. However, this solution would have to include all iptv services, not just those with youtube detected. So it is a bit of a departure from my original ticket. Thinking about how many cases enigma2 uses prefixes in url these days, and how it was in the past, makes me wonder how many prefixes will be in the future. Keeping track of what is new and what is old is also a complication. So maybe a prefix list as a future-proof feature is something to think about. |
I don't see a big problem. We can do, for example, as for the picons paths list in the settings dialog. But I think later. While there are other tasks. |
Оk. Changed.
Strange. Personally, I've seen examples of working links with an uppercase prefix. But in a zoo like Enigma2... :) I won’t be surprised if comes a request to reverse or change to uppercase with the new plugin version or next update of one of the Enigma images.
Unfortunately, it is a very difficult task to foresee all the options for incorrect user actions.I don't think it makes much sense also. |
True, is hard to predict every situation like that. I found one more thing during tests. |
Yes, I missed this option. Unfortunately it's difficult to notice all the nuances. Thx. I have added additional check. I hope together we will bring this feature to a working state. :) |
I will get back shortly to case sensitivity. I was talking only about one prefix and tested that, didn’t notice you changed all, two other were correct before. Anyway I use a fragment of code to be clear now.
added additional yt link checking (#170) Yes, this change works very well. There is also one special case when youtube links are used. Example This work best when there is one transmission per channel, so every start/stop of transmission means that “watch” link doesn't have to be updated. Although is not perfect, when there are multiple live transmissions on channel only one is selected, often not the main live broadcast on tv channels. With those new filter, when there is no yt link detection in this case, this can be defined as well regular with writing prefix manually. I don’t know if it is better to leave it that way or implement this exception, especially because use case is so limited. I mentioning it to be thorough. I also have one unrelated observation. |
Ok. Reverted.
I don't remember why, but I refused this option. It can be done optionally, but this requires a separate discussion. As for streams playback... |
Now is perfect.
I was thinking of something simpler, which is extending the youtube detection parameters by deleting the "watch?v=" part of the pattern, playback should be ok then. But I get it may be a part of fail safe about unforeseen actions or may be important to pass arguments to youtube_dl. Anyway, as I wrote, it was a special case, so not that important at this time. With this comment I close the topic as all initial issues have been resolved or explained. As a result, we also have a new feature. |
At the beginning I will say thanks for developing this program, it looks promising, but I discover some errors that I want to share with you.
One problem is about detecting entries with youtube URL and second is about formatting entries with youtube URL.
When I want to edit this entry I get a popup window. I'm clicking cancel, and then another popup which is exactly the same, second time cancel and it is finally able to edit.
Moreover when I'm pasting new url immediately the same popup appears or even when I want to modify the reference the same reaction. That is pretty annoying error.
The worst part is that there is no option to disable this detection. Please add that option.
I also tried to click ok but then, I got a info about conflicted versions with system one (linux), after solving that there is another problem.
A little information ahead. To watch youtube directly from channel list I need to have additional plugins from feed installed that act like proxy either is is streamlink or warpers like yp-dlp (introduced in for example openatv 7.x)
So the url is formatted with header it can be "http://127.0.0.1:8088/" or "YT-DLP://" but that header cannot be transferred to youtube-dl because it is causing problems, without header clicking ok is fine, but that is not the point to have an entry that box will not process.
Proper URL
YT-DLP://https://www.youtube.com/watch?v=i7D8laFtDsw
Proper bouquet entry
Entry after modification with DemonEditor, so I will call it corrupted bouquet entry
Where ? and = got converted as %3F and %3D, that should not be converted only ":"
I never saw that behavior in any other program, but formatting url like that may have influence on other IPTV links not only YouTube.
Surprisingly it works, but it will be rewritten when bouquet is edited by remote in "move mode"
Different method and this time I will present only proper entry
I tested this on linux version 3.5.0 Beta
I hope that reproducing and fixing that error will not be a big problem.
The text was updated successfully, but these errors were encountered: