Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: show SID as decimal instead of hex #34

Closed
vpont opened this issue Sep 8, 2020 · 10 comments
Closed

Feature: show SID as decimal instead of hex #34

vpont opened this issue Sep 8, 2020 · 10 comments
Assignees

Comments

@vpont
Copy link
Contributor

vpont commented Sep 8, 2020

In services' list it would really help me when comparing services with KingOfSat if one could choose between showing services' SIDs as decimal or hex numbers.

image

@DYefremov
Copy link
Owner

I think it will be useful. As an option, I can offer a context (pop-up) menu for the column header with the choice of the desired display.

@DYefremov DYefremov self-assigned this Sep 8, 2020
@DYefremov
Copy link
Owner

DYefremov commented Sep 11, 2020

Hi. I made a test implementation of this function.Perhaps she will suit you. But...
sid_as_decimal
DemonEditor_sid_as_decimal.zip

Unfortunately on big data (> 5000 rows in the main list) it can be slow. I tried several options and came to the conclusion that it would be optimal to do the following:
Option 1.
We're just adding a parameter to the preferences so that the sid value appears as decimal in tooltips! It is also possible to add a keyboard shortcut to switch mode.
Option 2.
We convert the values when loading data and again show them in tooltips. But here it is already desirable to restart the program!
Option 3.
Or we leave this test option(with popup menu) that is in the attachment.

Personally, I tend to the first option. I will be glad for your thoughts.

@vpont
Copy link
Contributor Author

vpont commented Sep 12, 2020

Hi.
What about keeping it simple and just add the SID in the tooltip in both formats, like this:
image
No extra config options or reloads.

@DYefremov
Copy link
Owner

Hi. Yes, that's a good option! We only need to select a display location in the main list. Alternatively after the service type or on the next line. I think the first option.

@vpont
Copy link
Contributor Author

vpont commented Sep 12, 2020

Maybe after the service type, in order to maintain consistency with the main window list?

@DYefremov
Copy link
Owner

Yes, it look ok too. Please test it.

@vpont
Copy link
Contributor Author

vpont commented Sep 12, 2020

Looks good to me!
Just that extra space in front of the decimal value:
image

@vpont
Copy link
Contributor Author

vpont commented Sep 12, 2020

And the hex value would look cleaner in upercase

@DYefremov
Copy link
Owner

Ok. Done!

@vpont
Copy link
Contributor Author

vpont commented Sep 13, 2020

Looks good, thank you!!

@vpont vpont closed this as completed Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants