Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/reponsive translate to window resize #5

Conversation

staywithme23
Copy link

subscribe to window EventListener , and dispatch the action to adjust translation value.

@staywithme23
Copy link
Author

staywithme23 commented Feb 6, 2019

@DZuz14 Hi, I create this simple fix to address the windows resize problem mentioned in I #2 .

  1. Basically, the fix is just subscribe to window size and send corresponding action.
  2. Each time you resize the window, still a bit of time is doing transition animation. I think the perfect solution (for solving resize and transition) is not switching slide by translation value but a way that you only render an active slide in a given time. sliding become reading different image.
  3. Thx for your code. I feel it is well written and straight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants