Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Internal Server Error on submitting empty bid #4

Merged
merged 7 commits into from
Mar 14, 2020
Merged

Fix Internal Server Error on submitting empty bid #4

merged 7 commits into from
Mar 14, 2020

Conversation

varunbln
Copy link
Contributor

Please make sure your issue complies with these guidelines:

    • Use same formatting
    • Changes must have been tested on PMMP.
    • Unless it is a minor code modification, you must use an IDE.
    • Have a detailed title (i.e "Fix Auctioned items remain in inventory")

What does the PR change?

This PR resolves Submitting Empty Bid
The issue was caused by not checking if the variable has been set.

Testing Environment

  • PocketMine-MP: 3.11.5
  • PHP: 7.2
  • Server OS: Windows 10

Extra Information

@DaPigGuy DaPigGuy merged commit 0a8d7f1 into DaPigGuy:master Mar 14, 2020
@varunbln varunbln deleted the quiccfix branch March 14, 2020 20:11
@Wengareki Wengareki mentioned this pull request Dec 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Submitting empty bid
3 participants
@varunbln @DaPigGuy @poggit-bot